Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:23092 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 27045 invoked by uid 1010); 2 May 2006 21:30:00 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 27028 invoked from network); 2 May 2006 21:30:00 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 May 2006 21:30:00 -0000 X-PHP-List-Original-Sender: list@firehawksystems.com X-Host-Fingerprint: 204.11.219.140 ls6.firehawksystems.com Received: from ([204.11.219.140:51088] helo=ls6.firehawksystems.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 0A/4F-05123-65FC7544 for ; Tue, 02 May 2006 17:29:58 -0400 Received: from [10.0.0.2] (ppp-70-229-26-129.dsl.ipltin.ameritech.net [70.229.26.129]) (authenticated bits=0) by ls6.firehawksystems.com (8.13.6/8.13.6) with ESMTP id k42LTigx054497; Tue, 2 May 2006 14:29:45 -0700 (PDT) In-Reply-To: <24e5f3b70605021356s551814a3md248db051a564bc1@mail.gmail.com> References: <7AE856D3-4727-47B2-BEDE-038427524E91@firehawksystems.com> <24e5f3b70605021356s551814a3md248db051a564bc1@mail.gmail.com> Mime-Version: 1.0 (Apple Message framework v749.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-ID: Cc: internals Content-Transfer-Encoding: 7bit Date: Tue, 2 May 2006 17:29:43 -0400 To: sterling.hughes@gmail.com X-Mailer: Apple Mail (2.749.3) X-Virus-Scanned: ClamAV version 0.88.2, clamav-milter version 0.88.2 on ls6.firehawksystems.com X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on ls6.firehawksystems.com Subject: Re: [PHP-DEV] Re: curl_multi_info_read patch review From: list@firehawksystems.com ("Brian J. France") PHP_5_1 and head or just head? It could be considered bug fix since curl_multi_info_read was there, but not implemented. Brian On May 2, 2006, at 4:56 PM, Sterling Hughes wrote: > please commit it, looks good. > > thanks, > sterling > > On 5/2/06, Brian J. France wrote: >> Some guys at work created this patch and have been running with it >> for a while now. >> >> Could I get a few more eyeballs on this? >> >> http://www.brianfrance.com/software/php/curl_multi_read.patch >> >> Quote from our internal bug: >> >> "The attached patch implements curl_multi_info_read(), as well as >> fixing some memory leak issues and reference problems in the original >> source." >> >> Should I keep it internal or commit it? >> >> Thanks, >> >> Brian >> > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >