Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:23090
Return-Path: <sterling.hughes@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 10239 invoked by uid 1010); 2 May 2006 20:56:14 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 10224 invoked from network); 2 May 2006 20:56:14 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 2 May 2006 20:56:14 -0000
X-PHP-List-Original-Sender: sterling.hughes@gmail.com
X-Host-Fingerprint: 64.233.162.205 nz-out-0102.google.com Linux 2.4/2.6
Received: from ([64.233.162.205:33673] helo=nz-out-0102.google.com)
	by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP
	id B0/FC-05123-D67C7544 for <internals@lists.php.net>; Tue, 02 May 2006 16:56:13 -0400
Received: by nz-out-0102.google.com with SMTP id l8so15382nzf
	for <internals@lists.php.net>; Tue, 02 May 2006 13:56:09 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
	s=beta; d=gmail.com;
	h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=NgnZxRshz8Tvf9ihpejhSorI++7sA8zkCRBxp66MqrFFPWA+eX3po4g9pP2gk49uO3VTbKVsAA+SvYs30qrNPx1LA5RiDg/Tt8yPn4dblCFfkxlnAsQQpLOVfM/sLFWNVpehSQ0xxZmWAKFWtsrx0fdyiy1nuI0ouk7PxPnJl58=
Received: by 10.65.242.15 with SMTP id u15mr733388qbr;
	Tue, 02 May 2006 13:56:01 -0700 (PDT)
Received: by 10.64.210.18 with HTTP; Tue, 2 May 2006 13:56:01 -0700 (PDT)
Message-ID: <24e5f3b70605021356s551814a3md248db051a564bc1@mail.gmail.com>
Date: Tue, 2 May 2006 13:56:01 -0700
Reply-To: sterling.hughes@gmail.com
To: "Brian J. France" <list@firehawksystems.com>
Cc: internals <internals@lists.php.net>, "Sterling Hughes" <sterling@php.net>
In-Reply-To: <7AE856D3-4727-47B2-BEDE-038427524E91@firehawksystems.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <7AE856D3-4727-47B2-BEDE-038427524E91@firehawksystems.com>
Subject: Re: curl_multi_info_read patch review
From: sterling.hughes@gmail.com ("Sterling Hughes")

please commit it, looks good.

thanks,
sterling

On 5/2/06, Brian J. France <list@firehawksystems.com> wrote:
> Some guys at work created this patch and have been running with it
> for a while now.
>
> Could I get a few more eyeballs on this?
>
> http://www.brianfrance.com/software/php/curl_multi_read.patch
>
> Quote from our internal bug:
>
>    "The attached patch implements curl_multi_info_read(), as well as
> fixing some memory leak issues and reference problems in the original
> source."
>
> Should I keep it internal or commit it?
>
> Thanks,
>
> Brian
>