Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:23093 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 29612 invoked by uid 1010); 2 May 2006 21:36:30 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 29595 invoked from network); 2 May 2006 21:36:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 May 2006 21:36:30 -0000 X-PHP-List-Original-Sender: sterling.hughes@gmail.com X-Host-Fingerprint: 64.233.162.206 nz-out-0102.google.com Linux 2.4/2.6 Received: from ([64.233.162.206:61653] helo=nz-out-0102.google.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id FA/9F-05123-DD0D7544 for ; Tue, 02 May 2006 17:36:29 -0400 Received: by nz-out-0102.google.com with SMTP id l8so23646nzf for ; Tue, 02 May 2006 14:36:26 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=JlBgtjNlKmJTsBSAZVFHg91HWilkjAWiJAOgTBx5T0z9L5zrb/Ik5DZ3Sjc8prxikLFZIvWB0VdR07uSo9knWu1KyVb0Fcc2kvPOb3YEoQFbI1aXhDODJlN0MQaTNUOZjhDoI00q+WI2BsHXoEgWTlZTeK/C9GMaGh2txa3s7MU= Received: by 10.65.242.15 with SMTP id u15mr753207qbr; Tue, 02 May 2006 14:36:26 -0700 (PDT) Received: by 10.64.210.18 with HTTP; Tue, 2 May 2006 14:36:25 -0700 (PDT) Message-ID: <24e5f3b70605021436k32282f0ai55686dbf2bd58ec4@mail.gmail.com> Date: Tue, 2 May 2006 14:36:25 -0700 Reply-To: sterling.hughes@gmail.com To: "Brian J. France" Cc: internals In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <7AE856D3-4727-47B2-BEDE-038427524E91@firehawksystems.com> <24e5f3b70605021356s551814a3md248db051a564bc1@mail.gmail.com> Subject: Re: [PHP-DEV] Re: curl_multi_info_read patch review From: sterling.hughes@gmail.com ("Sterling Hughes") not having tested it, i don't know. this is certainly a RM question, but if it doesn't break the compile, it does not look like it has the potential to damage previously existing infrastructure. -sterling On 5/2/06, Brian J. France wrote: > PHP_5_1 and head or just head? > > It could be considered bug fix since curl_multi_info_read was there, > but not implemented. > > Brian > > > On May 2, 2006, at 4:56 PM, Sterling Hughes wrote: > > please commit it, looks good. > > > > thanks, > > sterling > > > > On 5/2/06, Brian J. France wrote: > >> Some guys at work created this patch and have been running with it > >> for a while now. > >> > >> Could I get a few more eyeballs on this? > >> > >> http://www.brianfrance.com/software/php/curl_multi_read.patch > >> > >> Quote from our internal bug: > >> > >> "The attached patch implements curl_multi_info_read(), as well as > >> fixing some memory leak issues and reference problems in the original > >> source." > >> > >> Should I keep it internal or commit it? > >> > >> Thanks, > >> > >> Brian > >> > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > > >