Rename Fiber::this() to Fiber::getCurrent()

2 years ago by Aaron Piotrowski — view source

unread

Hi all,

During the Fiber RFC vote, several people noted that they objected to the name Fiber::this() for the method returning the currently executing Fiber object.

I'd like to propose renaming this method to Fiber::getCurrent(). A simple PR for the rename: https://github.com/php/php-src/pull/7155
Nothing has functionally changed about the method, only the name.

Fiber::current() is another possibility, but was not chosen because it may be conflated with Iterator::current().

Does anyone object to this rename? Shall we have a vote or is that not necessary?

Cheers,
Aaron Piotrowski

2 years ago by Larry Garfield — view source

unread

Hi all,

During the Fiber RFC vote, several people noted that they objected to
the name Fiber::this() for the method returning the currently executing
Fiber object.

I'd like to propose renaming this method to Fiber::getCurrent(). A
simple PR for the rename: https://github.com/php/php-src/pull/7155
Nothing has functionally changed about the method, only the name.

Fiber::current() is another possibility, but was not chosen because it
may be conflated with Iterator::current().

Does anyone object to this rename? Shall we have a vote or is that not
necessary?

Cheers,
Aaron Piotrowski

I support this change, and don't think it needs an RFC. I would vote for it if it were necessary, though.

--Larry Garfield

2 years ago by Joe Watkins — view source

unread

This doesn't look like the sort of detail we need to vote on.

It would be nice if this were made in time for the migration guide and
other doc to be prepared for 8.1.

Let's move forward, please ...

Cheers
Joe

Hi all,

During the Fiber RFC vote, several people noted that they objected to
the name Fiber::this() for the method returning the currently executing
Fiber object.

I'd like to propose renaming this method to Fiber::getCurrent(). A
simple PR for the rename: https://github.com/php/php-src/pull/7155
Nothing has functionally changed about the method, only the name.

Fiber::current() is another possibility, but was not chosen because it
may be conflated with Iterator::current().

Does anyone object to this rename? Shall we have a vote or is that not
necessary?

Cheers,
Aaron Piotrowski

I support this change, and don't think it needs an RFC. I would vote for
it if it were necessary, though.

--Larry Garfield

--

To unsubscribe, visit: https://www.php.net/unsub.php