Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114895
MIME-Version: 1.0
References: <F704DF32-F531-41CC-B326-7F0CD6DBDA50@trowski.com> <78321294-b416-4d0d-a170-3f6f424ea7b4@www.fastmail.com>
In-Reply-To: <78321294-b416-4d0d-a170-3f6f424ea7b4@www.fastmail.com>
Date: Tue, 15 Jun 2021 23:11:54 +0200
Message-ID: <CAOwTYAucxQ05b6t6yPEyQEZxyJFuFPO-PaCbw_GeAZiyT_9LSA@mail.gmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000010daf905c4d46d79"
Subject: Re: [PHP-DEV] Rename Fiber::this() to Fiber::getCurrent()
From: krakjoe@gmail.com (Joe Watkins)

--00000000000010daf905c4d46d79
Content-Type: text/plain; charset="UTF-8"

This doesn't look like the sort of detail we need to vote on.

It would be nice if this were made in time for the migration guide and
other doc to be prepared for 8.1.

Let's move forward, please ...

Cheers
Joe

On Tue, 15 Jun 2021 at 21:54, Larry Garfield <larry@garfieldtech.com> wrote:

> On Tue, Jun 15, 2021, at 2:01 PM, Aaron Piotrowski wrote:
> > Hi all,
> >
> > During the Fiber RFC vote, several people noted that they objected to
> > the name Fiber::this() for the method returning the currently executing
> > Fiber object.
> >
> > I'd like to propose renaming this method to Fiber::getCurrent(). A
> > simple PR for the rename: https://github.com/php/php-src/pull/7155
> > Nothing has functionally changed about the method, only the name.
> >
> > Fiber::current() is another possibility, but was not chosen because it
> > may be conflated with Iterator::current().
> >
> > Does anyone object to this rename? Shall we have a vote or is that not
> > necessary?
> >
> > Cheers,
> > Aaron Piotrowski
>
> I support this change, and don't think it needs an RFC.  I would vote for
> it if it were necessary, though.
>
> --Larry Garfield
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--00000000000010daf905c4d46d79--