Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:114893 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 17634 invoked from network); 15 Jun 2021 18:45:03 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 15 Jun 2021 18:45:03 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 13E161804C0 for ; Tue, 15 Jun 2021 12:01:38 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mercury.negativeion.net (mercury.negativeion.net [199.38.81.6]) by php-smtp4.php.net (Postfix) with ESMTP for ; Tue, 15 Jun 2021 12:01:37 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mercury.negativeion.net (Postfix) with ESMTP id 47C6820DDED28B for ; Tue, 15 Jun 2021 15:01:37 -0400 (EDT) Received: from mercury.negativeion.net ([127.0.0.1]) by localhost (mercury.negativeion.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KQlS7_yjQCgB for ; Tue, 15 Jun 2021 15:01:36 -0400 (EDT) Received: from [10.0.1.2] (unknown [173.225.157.10]) by mercury.negativeion.net (Postfix) with ESMTPSA id BA35F20DDED27F for ; Tue, 15 Jun 2021 15:01:36 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Message-ID: Date: Tue, 15 Jun 2021 14:01:29 -0500 To: php internals X-Mailer: Apple Mail (2.3608.120.23.2.4) Subject: Rename Fiber::this() to Fiber::getCurrent() From: aaron@trowski.com (Aaron Piotrowski) Hi all, During the Fiber RFC vote, several people noted that they objected to = the name Fiber::this() for the method returning the currently executing = Fiber object. I'd like to propose renaming this method to Fiber::getCurrent(). A = simple PR for the rename: https://github.com/php/php-src/pull/7155 Nothing has functionally changed about the method, only the name. Fiber::current() is another possibility, but was not chosen because it = may be conflated with Iterator::current(). Does anyone object to this rename? Shall we have a vote or is that not = necessary? Cheers, Aaron Piotrowski