Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114894
User-Agent: Cyrus-JMAP/3.5.0-alpha0-519-g27a961944e-fm-20210531.001-g27a96194
Mime-Version: 1.0
Message-ID: <78321294-b416-4d0d-a170-3f6f424ea7b4@www.fastmail.com>
In-Reply-To: <F704DF32-F531-41CC-B326-7F0CD6DBDA50@trowski.com>
References: <F704DF32-F531-41CC-B326-7F0CD6DBDA50@trowski.com>
Date: Tue, 15 Jun 2021 14:53:48 -0500
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain
Subject: Re: [PHP-DEV] Rename Fiber::this() to Fiber::getCurrent()
From: larry@garfieldtech.com ("Larry Garfield")

On Tue, Jun 15, 2021, at 2:01 PM, Aaron Piotrowski wrote:
> Hi all,
> 
> During the Fiber RFC vote, several people noted that they objected to 
> the name Fiber::this() for the method returning the currently executing 
> Fiber object.
> 
> I'd like to propose renaming this method to Fiber::getCurrent(). A 
> simple PR for the rename: https://github.com/php/php-src/pull/7155
> Nothing has functionally changed about the method, only the name.
> 
> Fiber::current() is another possibility, but was not chosen because it 
> may be conflated with Iterator::current().
> 
> Does anyone object to this rename? Shall we have a vote or is that not 
> necessary?
> 
> Cheers,
> Aaron Piotrowski

I support this change, and don't think it needs an RFC.  I would vote for it if it were necessary, though.

--Larry Garfield