[RFC] class_name:namespace View as Markdown

I'm Sorry, I feel a little nervous by writing here again after long time.

Replace '/' by '' and PATH( HELPER_PATH | SERVICE_PATH ) by NAMESPACE( HELPER_NAMESPACE | SERVICE_NAMESPACE ).

Sorry

---- En vie, 26 feb 2021 09:16:18 +0100 Manuel Canga php@manuelcanga.dev escribió ----

Hello, another example with "factories method"1:

use MyProject\Framework;

abstract class AbstractController {
    private const HELPER_PATH = static::namespace.'/Helpers';
    private const SERVICE_PATH = static::namespace.'/Services';

     public function instanceHelper( string $helperClass ) {
            $helperClassName = self::HELPER_PATH."/{$helperClass}";

           return new $helperClassName();
    }

   public function instanceService( string $serviceClass )  {
            $serviceClassName = self::SERVICE_PATH."/{$serviceClass}";

           return new $serviceClassName();
   }
}

use MyProject\MyModule;

class Controller {
    public function __invoke() {
                 //......
       $date = $this->instanceHelper('Date');
              //...
    }

}

Regards

Manuel Canga

Zend Certified PHP Engineer
Websites: https://manuelcanga.dev | https://trasweb.net
Linkedin: https://es.linkedin.com/in/manuelcanga

--

To unsubscribe, visit: https://www.php.net/unsub.php

Le 26 févr. 2021 à 09:16, Manuel Canga php@manuelcanga.dev a écrit :

Hello, another example with "factories method"1:

use MyProject\Framework;

abstract class AbstractController {
 private const HELPER_PATH = static::namespace.'/Helpers';
 private const SERVICE_PATH = static::namespace.'/Services';

  public function instanceHelper( string $helperClass ) {
         $helperClassName = self::HELPER_PATH."/{$helperClass}";

        return new $helperClassName();
 }

public function instanceService( string $serviceClass )  {
         $serviceClassName = self::SERVICE_PATH."/{$serviceClass}";

        return new $serviceClassName();
}
}

use MyProject\MyModule;

class Controller {
 public function __invoke() {
              //......
    $date = $this->instanceHelper('Date');
           //...
 }

}

Regards

Manuel Canga

Zend Certified PHP Engineer
Websites: https://manuelcanga.dev | https://trasweb.net
Linkedin: https://es.linkedin.com/in/manuelcanga

--

To unsubscribe, visit: https://www.php.net/unsub.php

Hi,

Note that (typos aside) this example cannot work as-is, because static::namespace (like static::class) cannot be resolved at compile-time, and therefore cannot be assigned to a constant.

More generally, in the various examples you provided, the namespace is not resolved at compile-time: it is either static::namespace or $fullClassName::namespace where $fullClassName is provided by the autoloader. As such, instead of a ::namespace magic class constant, it might be more appropriate to have a helper function, say get_namespace(), which has the additional benefit to work not only on (fully qualified) class names, but also on function, constant and namespace names (in the case of namespace names, it would return the name of the parent namespace).

—Claude

Hi Manuel,

pt., 26 lut 2021 o 09:17 Manuel Canga php@manuelcanga.dev napisał(a):

Hello, another example with "factories method"1:

use MyProject\Framework;

abstract class AbstractController {
    private const HELPER_PATH = static::namespace.'/Helpers';
    private const SERVICE_PATH = static::namespace.'/Services';

     public function instanceHelper( string $helperClass ) {
            $helperClassName = self::HELPER_PATH."/{$helperClass}";

           return new $helperClassName();
    }

   public function instanceService( string $serviceClass )  {
            $serviceClassName = self::SERVICE_PATH."/{$serviceClass}";

           return new $serviceClassName();
   }
}

use MyProject\MyModule;

class Controller {
    public function __invoke() {
                 //......
       $date = $this->instanceHelper('Date');
              //...
    }

}

Personally, none of the above examples is convincing bc I'd implement them
using a fixed class names map to avoid loading untrusted classes.
Any kind of helper class is something I'd personally not use to avoid
static coupling of code and hacks while writing unit tests over
services that could be injected by IoC.
Full class names (whether they're aliased or used in use clause) have more
benefit over class name string operations as they're easy for any renaming
which most of the IDE's these days can handle.
IMO introducing namespace magic constant has relatively narrow use and I'd
probably vote NO on this.

Cheers,
Michał Marcin Brzuchalski