Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113286
MIME-Version: 1.0
References: <177db7bbf72.ecf4615f732310.8822018854991483226@manuelcanga.dev> <177dd68f109.c748581d17565.7200783349436492456@manuelcanga.dev>
In-Reply-To: <177dd68f109.c748581d17565.7200783349436492456@manuelcanga.dev>
Date: Fri, 26 Feb 2021 13:25:30 +0100
Message-ID: <CABdc3WqAur4yR9a-jSXG79_UQHUP70vebHGOyAUOtDJucyh-Hw@mail.gmail.com>
To: Manuel Canga <php@manuelcanga.dev>
Cc: David Gebler <davidgebler@gmail.com>, Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000cbcdb105bc3c5d8c"
Subject: Re: [PHP-DEV] [RFC] class_name:namespace
From: michal.brzuchalski@gmail.com (=?UTF-8?Q?Micha=C5=82_Marcin_Brzuchalski?=)

--000000000000cbcdb105bc3c5d8c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Manuel,

pt., 26 lut 2021 o 09:17 Manuel Canga <php@manuelcanga.dev> napisa=C5=82(a)=
:

> Hello, another example with "factories method"[1]:
>
> ```php
> use MyProject\Framework;
>
> abstract class AbstractController {
>     private const HELPER_PATH =3D static::namespace.'/Helpers';
>     private const SERVICE_PATH =3D static::namespace.'/Services';
>
>      public function instanceHelper( string $helperClass ) {
>             $helperClassName =3D self::HELPER_PATH."/{$helperClass}";
>
>            return new $helperClassName();
>     }
>
>    public function instanceService( string $serviceClass )  {
>             $serviceClassName =3D self::SERVICE_PATH."/{$serviceClass}";
>
>            return new $serviceClassName();
>    }
> }
>
> use MyProject\MyModule;
>
> class Controller {
>     public function __invoke() {
>                  //......
>        $date =3D $this->instanceHelper('Date');
>               //...
>     }
>
> }
> ```
>
> [1]: https://en.wikipedia.org/wiki/Factory_method_pattern


Personally, none of the above examples is convincing bc I'd implement them
using a fixed class names map to avoid loading untrusted classes.
Any kind of helper class is something I'd personally not use to avoid
static coupling of code and hacks while writing unit tests over
services that could be injected by IoC.
Full class names (whether they're aliased or used in use clause) have more
benefit over class name string operations as they're easy for any renaming
which most of the IDE's these days can handle.
IMO introducing namespace magic constant has relatively narrow use and I'd
probably vote NO on this.

Cheers,
Micha=C5=82 Marcin Brzuchalski

--000000000000cbcdb105bc3c5d8c--