Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113284
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
In-Reply-To: <177dd68f109.c748581d17565.7200783349436492456@manuelcanga.dev>
Date: Fri, 26 Feb 2021 12:23:53 +0100
Cc: David Gebler <davidgebler@gmail.com>,
 Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <B425F747-0B02-4240-B003-244821CBAE90@gmail.com>
References: <177db7bbf72.ecf4615f732310.8822018854991483226@manuelcanga.dev>
 <177dd68f109.c748581d17565.7200783349436492456@manuelcanga.dev>
To: Manuel Canga <php@manuelcanga.dev>
Subject: Re: [PHP-DEV] [RFC] class_name:namespace
From: claude.pache@gmail.com (Claude Pache)



> Le 26 f=C3=A9vr. 2021 =C3=A0 09:16, Manuel Canga <php@manuelcanga.dev> =
a =C3=A9crit :
>=20
> Hello, another example with "factories method"[1]:
>=20
> ```php
> use MyProject\Framework;
>=20
> abstract class AbstractController {
>  private const HELPER_PATH =3D static::namespace.'/Helpers';
>  private const SERVICE_PATH =3D static::namespace.'/Services';
>=20
>   public function instanceHelper( string $helperClass ) {
>          $helperClassName =3D self::HELPER_PATH."/{$helperClass}";
>=20
>         return new $helperClassName();
>  }
>=20
> public function instanceService( string $serviceClass )  {
>          $serviceClassName =3D self::SERVICE_PATH."/{$serviceClass}";
>=20
>         return new $serviceClassName();
> }
> }
>=20
> use MyProject\MyModule;
>=20
> class Controller {
>  public function __invoke() {
>               //......
>     $date =3D $this->instanceHelper('Date');
>            //...
>  }
>=20
> }
> ```
>=20
> [1]: https://en.wikipedia.org/wiki/Factory_method_pattern
>=20
> Regards
> --
> Manuel Canga
>=20
> Zend Certified PHP Engineer=20
> Websites: https://manuelcanga.dev | https://trasweb.net
> Linkedin: https://es.linkedin.com/in/manuelcanga
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php

Hi,

Note that (typos aside) this example cannot work as-is, because =
`static::namespace` (like `static::class`) cannot be resolved at =
compile-time, and therefore cannot be assigned to a constant.

More generally, in the various examples you provided, the namespace is =
not resolved at compile-time: it is either static::namespace or =
$fullClassName::namespace where $fullClassName is provided by the =
autoloader. As such, instead of a ::namespace magic class constant, it =
might be more appropriate to have a helper function, say =
`get_namespace()`, which has the additional benefit to work not only on =
(fully qualified) class names, but also on function, constant and =
namespace names (in the case of namespace names, it would return the =
name of the parent namespace).

=E2=80=94Claude