pdo_dblib pull requests

8 years ago by Adam Baratz — view source

unread

Hi,

I work for the rare company that uses Linux PHP servers with MSSQL. We rely
quite a bit on this extension and have invested a little in some feature
improvements. I'd like to get them pushed upstream, but given the
relatively low usage of this extension, it seems like PRs easily get stuck
in limbo because of the difficulty in testing/verifying them (e.g.,
https://github.com/php/php-src/pull/1122). What process would people
recommend for sharing our work?

Thanks,
Adam

8 years ago by Lior Kaplan — view source

unread

Hi Adam,

First, thanks for contributing.

I think the best way would be to try and provide tests (part of the PR) and test environment for this change.

If the latter can't be provided, maybe instructions how to create one (as you guys probably have far more experience then us).

Kaplan

8 years ago by Adam Baratz — view source

unread

I think the best way would be to try and provide tests (part of the PR)
and test environment for this change.

If the latter can't be provided, maybe instructions how to create one (as
you guys probably have far more experience then us).

I'll certainly provide tests. Maybe this vagrant box could be of use?
https://github.com/fgrehm/vagrant-mssql-express