Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:91186 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 86185 invoked from network); 10 Feb 2016 16:13:29 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Feb 2016 16:13:29 -0000 Authentication-Results: pb1.pair.com smtp.mail=adam.baratz@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=adam.baratz@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender) X-PHP-List-Original-Sender: adam.baratz@gmail.com X-Host-Fingerprint: 209.85.213.170 mail-ig0-f170.google.com Received: from [209.85.213.170] ([209.85.213.170:37761] helo=mail-ig0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 90/26-12072-8A16BB65 for ; Wed, 10 Feb 2016 11:13:29 -0500 Received: by mail-ig0-f170.google.com with SMTP id 5so17550566igt.0 for ; Wed, 10 Feb 2016 08:13:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=cs/RBSDtiZ5B7vdBryN8jbfP8fc3296yhuujJTaxUPg=; b=jt/ROmRsQj11dWgL46PTHVmfpwf1zDphAUUdgNhcy3epG7Hd+eZxVrYU9eW3hYA3Xk A0Ou29wl/j01Au6lR9U8HF0Cumsg5ZyaKEWrjvPmuLoENRZmzi+j3ZRBJ6i8MLhun7tz WjJijLbjPfGk9vX2RVdJMVZdkASKRWIT9WGpPgzSfiXuk4vvAU4SHZWHnBHHzm7rclJf lvCXtMF9nRpk/mzxG1qL5J74IGra3I5MIld5x5qQV+N8Fpl8RFy+R6vwDCpRMiYjNljI iFFfQgHca0hVQek/NBjDKe0wx9KemlSXg6lY+640giLnaR4zKtjWQ7Mra/XEdbz2pZ5e xxXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=cs/RBSDtiZ5B7vdBryN8jbfP8fc3296yhuujJTaxUPg=; b=Jwbg++okNmgAp+eZcu/Ul6RZXgih5JbtMxFvM9ej8lxWZBE450cNYGf6Zg3D+OXNpA 2iz3SGXf9EZugZ0ghHms0uWKjcnf41sV7QjhkacR6yP0sn0zzF009UZnPTKfT3C3HaBK A5jJ8LEY9dwp5QqGkAAX2nYokARhSXRraDbZIQ6speZ15/v5RGVnZza0je8lW15Gqoi7 OenJnW1y+Pcth0ytad3Z7X5D/dpGsUERk1mCGBYWio5wh/mRsmFIDIJuwEp/Na0Gdiwy IPv7xVS9ilF5InyYSCA9Twvzzt7Pjra0CzWqu+FDDYTNLisNuoRZh9DUYTJ2/BAMzz+M B6yg== X-Gm-Message-State: AG10YOQQxBxcrl7zq0YKWrttUkp0jU28R65g6TAZRGgW6Vqi1r91FA25MtH12JcdjCOzqj97vSOhb/ISBTHamQ== MIME-Version: 1.0 X-Received: by 10.50.8.102 with SMTP id q6mr8016773iga.44.1455120805750; Wed, 10 Feb 2016 08:13:25 -0800 (PST) Received: by 10.64.116.167 with HTTP; Wed, 10 Feb 2016 08:13:25 -0800 (PST) In-Reply-To: References: Date: Wed, 10 Feb 2016 11:13:25 -0500 Message-ID: To: Lior Kaplan Cc: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=089e0118482cbb70a1052b6cb617 Subject: Re: [PHP-DEV] pdo_dblib pull requests From: adam.baratz@gmail.com (Adam Baratz) --089e0118482cbb70a1052b6cb617 Content-Type: text/plain; charset=UTF-8 > > I think the best way would be to try and provide tests (part of the PR) > and test environment for this change. > > If the latter can't be provided, maybe instructions how to create one (as > you guys probably have far more experience then us). I'll certainly provide tests. Maybe this vagrant box could be of use? https://github.com/fgrehm/vagrant-mssql-express --089e0118482cbb70a1052b6cb617--