Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:91103 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 39640 invoked from network); 6 Feb 2016 22:09:28 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Feb 2016 22:09:28 -0000 Authentication-Results: pb1.pair.com header.from=lior.k@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=lior.k@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 157.56.110.109 as permitted sender) X-PHP-List-Original-Sender: lior.k@zend.com X-Host-Fingerprint: 157.56.110.109 mail-bn1bn0109.outbound.protection.outlook.com Received: from [157.56.110.109] ([157.56.110.109:40066] helo=na01-bn1-obe.outbound.protection.outlook.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BD/E4-28222-51F66B65 for ; Sat, 06 Feb 2016 17:09:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=RWSoftware.onmicrosoft.com; s=selector1-zend-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=BcTfMKxOqcHIXIJ2/SH+gczb/kLp+WqH8jEuQB5r0ws=; b=j065i/lBY6XrVKwcX3L1kRFTEXeDI9LF2iNLMZ5MYLIH/NO/8qjWN5oSLwYp4I/gzSpVH+tTEA7zf49PQ8ADOYCR/KeugiFi27AwE4cqdWOw9eBT1M/xR2zeWpattCtiyw6rNL1qh/V0BKvHrwRIAQ3ZWeoT+N1a5Y9IUa//SrA= Received: from CY1PR0201MB0826.namprd02.prod.outlook.com (10.160.141.27) by CY1PR0201MB0828.namprd02.prod.outlook.com (10.160.142.11) with Microsoft SMTP Server (TLS) id 15.1.396.15; Sat, 6 Feb 2016 22:09:21 +0000 Received: from CY1PR0201MB0826.namprd02.prod.outlook.com ([10.160.141.27]) by CY1PR0201MB0826.namprd02.prod.outlook.com ([10.160.141.27]) with mapi id 15.01.0396.020; Sat, 6 Feb 2016 22:09:21 +0000 To: Adam Baratz CC: "internals@lists.php.net" Thread-Topic: [PHP-DEV] pdo_dblib pull requests Thread-Index: AQHRYD/BPzHY4B+EBkCaHhSFD1vIeJ8flPAu Date: Sat, 6 Feb 2016 22:09:21 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lists.php.net; dkim=none (message not signed) header.d=none;lists.php.net; dmarc=none action=none header.from=zend.com; x-originating-ip: [84.111.37.184] x-microsoft-exchange-diagnostics: 1;CY1PR0201MB0828;5:v9Nq6fCCU/XTss0no8MDp+CRUGM1qK7Hqd0sMlrOmAD6jkZFP1P5LNuc7BWsPgKKtyPnAqSQA5PDRrs/vTmThyCCgU2hU0yTi0D5SxZCYIeJBGt7ZAPQApfo6+cDNA1OWszJeSJtlhPMY17l/Tf2TA==;24:iugGNJRJiUg0nYpnK0FH1EdB7Rv4X5kvLY4U8+pBqW1pHKiZEkvljF1Me5W/qMRtH/p/rCPrIDIe1bSrzI8iUTdrIart2V/vxx/OwK95/78= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB0828; x-ms-office365-filtering-correlation-id: aaee15ac-07a7-4731-7368-08d32f422a50 x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:CY1PR0201MB0828;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB0828; x-forefront-prvs: 08444C7C87 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(52604005)(377454003)(164054003)(74316001)(5008740100001)(33656002)(4326007)(11100500001)(76576001)(189998001)(92566002)(5003600100002)(110136002)(66066001)(3660700001)(40100003)(77096005)(5001960100002)(19580405001)(15975445007)(10400500002)(2950100001)(3900700001)(122556002)(19580395003)(5002640100001)(50986999)(87936001)(76176999)(86362001)(5004730100002)(3280700002)(586003)(1220700001)(102836003)(54356999)(3846002)(106116001)(1096002)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0201MB0828;H:CY1PR0201MB0826.namprd02.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: zend.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2016 22:09:21.2071 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB0828 Subject: Re: [PHP-DEV] pdo_dblib pull requests From: lior.k@zend.com (Lior Kaplan) Hi Adam, First, thanks for contributing. I think the best way would be to try and provide tests (part of the PR) and= test environment for this change. If the latter can't be provided, maybe instructions how to create one (as y= ou guys probably have far more experience then us). Kaplan ________________________________________ From: Adam Baratz Sent: Friday, February 5, 2016 8:04 PM To: internals@lists.php.net Subject: [PHP-DEV] pdo_dblib pull requests Hi, I work for the rare company that uses Linux PHP servers with MSSQL. We rely quite a bit on this extension and have invested a little in some feature improvements. I'd like to get them pushed upstream, but given the relatively low usage of this extension, it seems like PRs easily get stuck in limbo because of the difficulty in testing/verifying them (e.g., https://github.com/php/php-src/pull/1122). What process would people recommend for sharing our work? Thanks, Adam=