[PHP-CVS] com php-src: Change E_ERROR and some E_WARNING to E_RECOVERABLE_ERROR.: ext/session/mod_user.c ext/session/mod_user_class.c ext/session/session.c ext/session/tests/bug60860.phpt ext/session/tests/bug66481.phpt ext/session/tests/bug67972.phpt

11 years ago by Anatol Belski — view source — reply

unread

Hi Yasuo,

Changing E_ERROR to E_RECOVERABLE_ERROR is probably ok where it is safe, but changing E_WARNING to E_RECOVERABLE_ERROR is a BC break.

Thanks

Anatol

-----Original Message-----
From: Yasuo Ohgaki [mailto:yohgaki@php.net]
Sent: Tuesday, July 21, 2015 5:59 AM
To: php-cvs@lists.php.net
Subject: [PHP-CVS] com php-src: Change E_ERROR and some E_WARNING to
E_RECOVERABLE_ERROR.: ext/session/mod_user.c
ext/session/mod_user_class.c ext/session/session.c
ext/session/tests/bug60860.phpt ext/session/tests/bug66481.phpt
ext/session/tests/bug67972.phpt ext

Commit: ad4533fdbabcc3e545277e30023b2fdce16297a0
Author: Yasuo Ohgaki yohgaki@php.net Tue, 21 Jul 2015 12:59:23
+0900
Parents: 22767a48a7bd060f3397713dfe5f2a5581496097
Branches: master

Link: http://git.php.net/?p=php-
src.git;a=commitdiff;h=ad4533fdbabcc3e545277e30023b2fdce16297a0

Log:
Change E_ERROR and some E_WARNING to E_RECOVERABLE_ERROR.

Changed paths:
M ext/session/mod_user.c
M ext/session/mod_user_class.c
M ext/session/session.c
M ext/session/tests/bug60860.phpt
M ext/session/tests/bug66481.phpt
M ext/session/tests/bug67972.phpt
M ext/session/tests/session_module_name_variation3.phpt
M ext/session/tests/session_name_error.phpt
M ext/session/tests/session_name_variation1.phpt
M ext/session/tests/session_save_path_variation4.phpt
M ext/session/tests/session_set_save_handler_class_014.phpt
M ext/session/tests/session_set_save_handler_error3.phpt
M ext/session/tests/session_set_save_handler_sid_002.phpt

11 years ago by Yasuo Ohgaki — view source — reply

unread

Hi Anatol,

On Tue, Jul 21, 2015 at 3:06 PM, Anatol Belski anatol.php@belski.net
wrote:

Changing E_ERROR to E_RECOVERABLE_ERROR is probably ok where it is safe,
but changing E_WARNING to E_RECOVERABLE_ERROR is a BC break.

I agree it's BC.
E_ERROR does not give users a chance for graceful script termination and
E_WARNING is
used instead.

This is the only reason why E_WARNING is used before. However, users may
continue
execution with the default setting. I think it's not good to continue with
fatal setting errors,
but I don't mind changing these errors back to E_WARNING.
It's your call.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

11 years ago by Anatol Belski — view source — reply

unread

-----Original Message-----
From: yohgaki@gmail.com [mailto:yohgaki@gmail.com] On Behalf Of Yasuo
Ohgaki
Sent: Tuesday, July 21, 2015 8:24 AM
To: Anatol Belski anatol.php@belski.net
Cc: Yasuo Ohgaki yohgaki@php.net; php-cvs@lists.php.net; Internals
internals@lists.php.net
Subject: Re: [PHP-CVS] com php-src: Change E_ERROR and some E_WARNING
to E_RECOVERABLE_ERROR.: ext/session/mod_user.c
ext/session/mod_user_class.c ext/session/session.c
ext/session/tests/bug60860.phpt ext/session/tests/bug66481.phpt
ext/session/tests/bug67972.phpt

Hi Anatol,

On Tue, Jul 21, 2015 at 3:06 PM, Anatol Belski anatol.php@belski.net
wrote:

Changing E_ERROR to E_RECOVERABLE_ERROR is probably ok where it is
safe, but changing E_WARNING to E_RECOVERABLE_ERROR is a BC break.

I agree it's BC.
E_ERROR does not give users a chance for graceful script termination and
E_WARNING is used instead.

This is the only reason why E_WARNING is used before. However, users may
continue execution with the default setting. I think it's not good to continue with
fatal setting errors, but I don't mind changing these errors back to E_WARNING.
It's your call.
Yeah, please let's not change E_WARNING as it's an obvious and unnecessary BC break with PHP5. If you could please change them back, IMHO the rest were acceptable.

Btw there's also a thread there about "exceptions in the functions". IMHO we should retain the old behaviors regarding this subject until there's no strategy came out from there.

Regards

Anatol