Newsgroups: php.cvs,php.internals
Path: news.php.net
Xref: news.php.net php.cvs:88082 php.internals:87216
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Yasuo Ohgaki'" <yohgaki@ohgaki.net>
Cc: "'Yasuo Ohgaki'" <yohgaki@php.net>,
	<php-cvs@lists.php.net>,
	"'Internals'" <internals@lists.php.net>
References: <005a01d0c37b$5fc90e30$1f5b2a90$@belski.net> <CAGa2bXbNY0nXWDDEb80cPnJAWz+fogJbkxJrRmm5iRAef8gw1g@mail.gmail.com>
In-Reply-To: <CAGa2bXbNY0nXWDDEb80cPnJAWz+fogJbkxJrRmm5iRAef8gw1g@mail.gmail.com>
Date: Tue, 21 Jul 2015 08:46:50 +0200
Message-ID: <007501d0c381$072495a0$156dc0e0$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQGturx5WXTQW3Jcnu+pU9VZGSaBWwHGgzCknh1WGVA=
Content-Language: en-us
Subject: RE: [PHP-CVS] com php-src: Change E_ERROR and some E_WARNING to E_RECOVERABLE_ERROR.: ext/session/mod_user.c ext/session/mod_user_class.c ext/session/session.c ext/session/tests/bug60860.phpt ext/session/tests/bug66481.phpt ext/session/tests/bug67972.phpt
From: anatol.php@belski.net ("Anatol Belski")



> -----Original Message-----
> From: yohgaki@gmail.com [mailto:yohgaki@gmail.com] On Behalf Of Yasuo
> Ohgaki
> Sent: Tuesday, July 21, 2015 8:24 AM
> To: Anatol Belski <anatol.php@belski.net>
> Cc: Yasuo Ohgaki <yohgaki@php.net>; php-cvs@lists.php.net; Internals
> <internals@lists.php.net>
> Subject: Re: [PHP-CVS] com php-src: Change E_ERROR and some E_WARNING
> to E_RECOVERABLE_ERROR.: ext/session/mod_user.c
> ext/session/mod_user_class.c ext/session/session.c
> ext/session/tests/bug60860.phpt ext/session/tests/bug66481.phpt
> ext/session/tests/bug67972.phpt
>=20
> Hi Anatol,
>=20
> On Tue, Jul 21, 2015 at 3:06 PM, Anatol Belski <anatol.php@belski.net>
> wrote:
>=20
> > Changing E_ERROR to E_RECOVERABLE_ERROR is probably ok where it is
> > safe, but changing E_WARNING to E_RECOVERABLE_ERROR is a BC break.
>=20
>=20
> I agree it's BC.
> E_ERROR does not give users a chance for graceful script termination =
and
> E_WARNING is used instead.
>=20
> This is the only reason why E_WARNING is used before. However, users =
may
> continue execution with the default setting. I think it's not good to =
continue with
> fatal setting errors, but I don't mind changing these errors back to =
E_WARNING.
> It's your call.
Yeah, please let's not change E_WARNING as it's an obvious and =
unnecessary BC break with PHP5. If you could please change them back, =
IMHO the rest were acceptable.=20

Btw there's also a thread there about "exceptions in the functions". =
IMHO we should retain the old behaviors regarding this subject until =
there's no strategy came out from there.

Regards

Anatol