Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87215
Return-Path: <yohgaki@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 73068 invoked from network); 21 Jul 2015 06:24:42 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 21 Jul 2015 06:24:42 -0000
Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.179 as permitted sender)
X-PHP-List-Original-Sender: yohgaki@gmail.com
X-Host-Fingerprint: 209.85.160.179 mail-yk0-f179.google.com  
Received: from [209.85.160.179] ([209.85.160.179:34671] helo=mail-yk0-f179.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 0C/70-03461-8A5EDA55 for <internals@lists.php.net>; Tue, 21 Jul 2015 02:24:41 -0400
Received: by ykax123 with SMTP id x123so158025154yka.1;
        Mon, 20 Jul 2015 23:24:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:cc:content-type;
        bh=GdFQMEGvMZ3gSfa6rFwfV6TICS0p//Zd3eYuCM8FL3A=;
        b=HyBSDeDBDNjHLG3o5yS3heLPESwWwXSz5j7sNRknh/MijZL4V+kB7SRfmXD0PZTxFQ
         S4yqjEWCxWcBY/IgKL6MxNc9haSwPgY0t1TWmnKnmdz6w9i9CMbXQLmKYQLxr2iF2NuJ
         fSx8IxvrPkcVmdx6CPZ4k3tx8u88Qn3UMmicXQ7u9YZ2xL38K1ZDQ5TCwT5qFQt2ySwb
         +gxZJ8Cy8WAKlNfplSctY5tkfJI3owARVW7dHHQQJvzoh6li+gkPXWCypdvpUzS7fbgb
         k9mXGCksTX7iDECwoafrIlonxbfoQh/EguiI9E2uR4NEyy8MSSZANtF7dPvL16WSWizf
         r8OQ==
X-Received: by 10.129.98.198 with SMTP id w189mr30510515ywb.32.1437459876389;
 Mon, 20 Jul 2015 23:24:36 -0700 (PDT)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
Received: by 10.129.40.77 with HTTP; Mon, 20 Jul 2015 23:23:57 -0700 (PDT)
In-Reply-To: <005a01d0c37b$5fc90e30$1f5b2a90$@belski.net>
References: <005a01d0c37b$5fc90e30$1f5b2a90$@belski.net>
Date: Tue, 21 Jul 2015 15:23:57 +0900
X-Google-Sender-Auth: YSxSUAM90yUzjP2dDjJDxKi6p6o
Message-ID: <CAGa2bXbNY0nXWDDEb80cPnJAWz+fogJbkxJrRmm5iRAef8gw1g@mail.gmail.com>
To: Anatol Belski <anatol.php@belski.net>
Cc: Yasuo Ohgaki <yohgaki@php.net>, "php-cvs@lists.php.net" <php-cvs@lists.php.net>, 
	Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a114713b84fa938051b5cb5b1
Subject: Re: [PHP-CVS] com php-src: Change E_ERROR and some E_WARNING to
 E_RECOVERABLE_ERROR.: ext/session/mod_user.c ext/session/mod_user_class.c
 ext/session/session.c ext/session/tests/bug60860.phpt ext/session/tests/bug66481.phpt
 ext/session/tests/bug67972.phpt
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a114713b84fa938051b5cb5b1
Content-Type: text/plain; charset=UTF-8

Hi Anatol,

On Tue, Jul 21, 2015 at 3:06 PM, Anatol Belski <anatol.php@belski.net>
wrote:

> Changing E_ERROR to E_RECOVERABLE_ERROR is probably ok where it is safe,
> but changing E_WARNING to E_RECOVERABLE_ERROR is a BC break.


I agree it's BC.
E_ERROR does not give users a chance for graceful script termination and
E_WARNING is
used instead.

This is the only reason why E_WARNING is used before. However, users may
continue
execution with the default setting. I think it's not good to continue with
fatal setting errors,
but I don't mind changing these errors back to E_WARNING.
It's your call.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a114713b84fa938051b5cb5b1--