OK slowly getting back into raw code again ...
Looking at imagick phpinfo problem ...
if (supported_formats) {
for (i = 0; i < num_formats; i++) {
smart_string_appends(&formats, supported_formats[i]);
if (i != (num_formats - 1)) {
smart_string_appends(&formats, ", ");
}
IMAGICK_FREE_MAGICK_MEMORY(supported_formats[i]);
}
smart_string_0(&formats);
#ifdef ZEND_ENGINE_3
php_info_print_table_row(2, "ImageMagick supported formats", formats);
#else
php_info_print_table_row(2, "ImageMagick supported formats", formats.s);
#endif
smart_string_free(&formats);
IMAGICK_FREE_MAGICK_MEMORY(supported_formats);
}
This one of the few places I can find smart_string_appends used, and I
can't work out just where it's code is? Although what it should be doing
is fairly self explanatory ... except why the dropping of the .s for
ZEND_ENGINE_3 ?
supported_formats must have the list as it says there are 209 entries,
but why is there a problem doing something simple which works on the 5.x
builds.
--
Lester Caine - G8HFL
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk
Rainbow Digital Media - http://rainbowdigitalmedia.co.uk
Lester,
If you are having issues with Imagick please report them here:
https://github.com/mkoppanen/imagick
Not only is that the right place to report issues with unreleased
versions of Imagick, but also I tend to monitor issues there more
closely than I do a mailing list.
This one of the few places I can find smart_string_appends used, and I
can't work out just where it's code is?
lxr is your friend:
http://lxr.php.net/xref/PHP_TRUNK/ext/standard/php_smart_string.h#79
why is there a problem doing something simple which works on the 5.x
builds.
Apparently software can have bugs. Who knew! Seriously though, there
was a bug displaying the phpinfo page caused by the migration to the
7, but it's fixed now. If you're still having issues, please open an
issue in the link above.
cheers
Dan
( email addresses used to be easy! - get the right one )
Lester,
If you are having issues with Imagick please report them here:
https://github.com/mkoppanen/imagickNot only is that the right place to report issues with unreleased
versions of Imagick, but also I tend to monitor issues there more
closely than I do a mailing list.
imagick is just one of the packages I am looking at. The whole point of
this post was to get some help getting up to speed actually working with
the php-src code base. None of my notes from PHP4->5 days make any sense
as many of the methods used don't seem to match now ... such as
processing strings!
This one of the few places I can find smart_string_appends used, and I
can't work out just where it's code is?lxr is your friend:
http://lxr.php.net/xref/PHP_TRUNK/ext/standard/php_smart_string.h#79
Yep - got that - but converting it to English has me going around in
circles. IS the whole process covered in that file ... some comments
would be helpful.
why is there a problem doing something simple which works on the 5.x
builds.Apparently software can have bugs. Who knew! Seriously though, there
was a bug displaying the phpinfo page caused by the migration to the
7, but it's fixed now. If you're still having issues, please open an
issue in the link above.
Come on - did you really post that?
I am TRYING to spend some time being able to FIX the bugs since that
seems to be the requirement these days. I have not yet seen a fix for
imagick, but I think that may be down to the fact that we have several
forks of the code rather than it being part of php-src. THAT is just
another minefield for those of us who are trying to play catchup.
--
Lester Caine - G8HFL
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk
Rainbow Digital Media - http://rainbowdigitalmedia.co.uk
OK slowly getting back into raw code again ...
Looking at imagick phpinfo problem ...
if (supported_formats) { for (i = 0; i < num_formats; i++) { smart_string_appends(&formats,supported_formats[i]);
if (i != (num_formats - 1)) { smart_string_appends(&formats, ", "); } IMAGICK_FREE_MAGICK_MEMORY(supported_formats[i]); } smart_string_0(&formats);#ifdef ZEND_ENGINE_3
php_info_print_table_row(2, "ImageMagick supported
formats", formats);
#else
php_info_print_table_row(2, "ImageMagick supported
formats", formats.s);
#endif
smart_string_free(&formats);
IMAGICK_FREE_MAGICK_MEMORY(supported_formats);
}This one of the few places I can find smart_string_appends used, and I
can't work out just where it's code is? Although what it should be doing
is fairly self explanatory ... except why the dropping of the .s for
ZEND_ENGINE_3 ?
I hope this is the right pointer.
The String API changed completely in ZE3, see the Upgrading docs to PHPNG:
https://wiki.php.net/phpng-upgrading#strings
It takes much time wrapping your head around this new way, but I think in
the end its better than before.
supported_formats must have the list as it says there are 209 entries,
but why is there a problem doing something simple which works on the 5.x
builds.--
Lester Caine - G8HFLContact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk
Rainbow Digital Media - http://rainbowdigitalmedia.co.uk
Try again ... last attempt just vanished :(
I hope this is the right pointer.
The String API changed completely in ZE3, see the Upgrading docs to PHPNG:
https://wiki.php.net/phpng-upgrading#strings
It takes much time wrapping your head around this new way, but I think
in the end its better than before.
I've tried to work through that, but
Not all of the extensions code have to be converted to use zend_string instead of char*. It's up to extensions maintainer to decide which type is more suitable in each particular case.
does not help if one does not know how one decides ...
The main problem is that the smart_string section seems to have an
identity crisis? smart_str is till being used in the exmples. Any reaon
for that?
--
Lester Caine - G8HFL
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk
Rainbow Digital Media - http://rainbowdigitalmedia.co.uk