Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:82073 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 49611 invoked from network); 7 Feb 2015 00:56:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Feb 2015 00:56:50 -0000 Authentication-Results: pb1.pair.com header.from=lester@lsces.co.uk; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=lester@lsces.co.uk; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lsces.co.uk from 217.147.176.214 cause and error) X-PHP-List-Original-Sender: lester@lsces.co.uk X-Host-Fingerprint: 217.147.176.214 mail4-2.serversure.net Linux 2.6 Received: from [217.147.176.214] ([217.147.176.214:59598] helo=mail4.serversure.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F2/10-47159-FC265D45 for ; Fri, 06 Feb 2015 19:56:48 -0500 Received: (qmail 18424 invoked by uid 89); 7 Feb 2015 00:56:44 -0000 Received: by simscan 1.3.1 ppid: 18416, pid: 18420, t: 0.0670s scanners: attach: 1.3.1 clamav: 0.96/m:52/d:10677 Received: from unknown (HELO ?10.0.0.8?) (lester@rainbowdigitalmedia.org.uk@86.189.147.37) by mail4.serversure.net with ESMTPA; 7 Feb 2015 00:56:44 -0000 Message-ID: <54D562CC.3080403@lsces.co.uk> Date: Sat, 07 Feb 2015 00:56:44 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: PHP Internals Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Pointers to understanding code base From: lester@lsces.co.uk (Lester Caine) OK slowly getting back into raw code again ... Looking at imagick phpinfo problem ... > if (supported_formats) { > for (i = 0; i < num_formats; i++) { > smart_string_appends(&formats, supported_formats[i]); > if (i != (num_formats - 1)) { > smart_string_appends(&formats, ", "); > } > IMAGICK_FREE_MAGICK_MEMORY(supported_formats[i]); > } > smart_string_0(&formats); > #ifdef ZEND_ENGINE_3 > php_info_print_table_row(2, "ImageMagick supported formats", formats); > #else > php_info_print_table_row(2, "ImageMagick supported formats", formats.s); > #endif > smart_string_free(&formats); > IMAGICK_FREE_MAGICK_MEMORY(supported_formats); > } This one of the few places I can find smart_string_appends used, and I can't work out just where it's code is? Although what it should be doing is fairly self explanatory ... except why the dropping of the .s for ZEND_ENGINE_3 ? supported_formats must have the list as it says there are 209 entries, but why is there a problem doing something simple which works on the 5.x builds. -- Lester Caine - G8HFL ----------------------------- Contact - http://lsces.co.uk/wiki/?page=contact L.S.Caine Electronic Services - http://lsces.co.uk EnquirySolve - http://enquirysolve.com/ Model Engineers Digital Workshop - http://medw.co.uk Rainbow Digital Media - http://rainbowdigitalmedia.co.uk