Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82087
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain beberlei.de from 74.125.82.45 cause and error)
MIME-Version: 1.0
In-Reply-To: <54D562CC.3080403@lsces.co.uk>
References: <54D562CC.3080403@lsces.co.uk>
Date: Sat, 7 Feb 2015 11:30:40 +0100
Message-ID: <CAEPJdu=yfJje=M=7ZaxgcLAwZNzxkg7ZsybzO6aw6+Us9RYr9g@mail.gmail.com>
To: Lester Caine <lester@lsces.co.uk>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d0435c014603c00050e7d0719
Subject: Re: [PHP-DEV] Pointers to understanding code base
From: kontakt@beberlei.de (Benjamin Eberlei)

--f46d0435c014603c00050e7d0719
Content-Type: text/plain; charset=UTF-8

On Sat, Feb 7, 2015 at 1:56 AM, Lester Caine <lester@lsces.co.uk> wrote:

> OK slowly getting back into raw code again ...
>
> Looking at imagick phpinfo problem ...
>
> >       if (supported_formats) {
> >               for (i = 0; i < num_formats; i++) {
> >                       smart_string_appends(&formats,
> supported_formats[i]);
> >                       if (i != (num_formats - 1)) {
> >                               smart_string_appends(&formats, ", ");
> >                       }
> >                       IMAGICK_FREE_MAGICK_MEMORY(supported_formats[i]);
> >               }
> >               smart_string_0(&formats);
> > #ifdef ZEND_ENGINE_3
> >               php_info_print_table_row(2, "ImageMagick supported
> formats", formats);
> > #else
> >               php_info_print_table_row(2, "ImageMagick supported
> formats", formats.s);
> > #endif
> >               smart_string_free(&formats);
> >               IMAGICK_FREE_MAGICK_MEMORY(supported_formats);
> >       }
>
> This one of the few places I can find smart_string_appends used, and I
> can't work out just where it's code is? Although what it should be doing
> is fairly self explanatory ... except why the dropping of the .s for
> ZEND_ENGINE_3 ?
>

I hope this is the right pointer.

The String API changed completely in ZE3, see the Upgrading docs to PHPNG:

https://wiki.php.net/phpng-upgrading#strings

It takes much time wrapping your head around this new way, but I think in
the end its better than before.


>
> supported_formats must have the list as it says there are 209 entries,
> but why is there a problem doing something simple which works on the 5.x
> builds.
>
> --
> Lester Caine - G8HFL
> -----------------------------
> Contact - http://lsces.co.uk/wiki/?page=contact
> L.S.Caine Electronic Services - http://lsces.co.uk
> EnquirySolve - http://enquirysolve.com/
> Model Engineers Digital Workshop - http://medw.co.uk
> Rainbow Digital Media - http://rainbowdigitalmedia.co.uk
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--f46d0435c014603c00050e7d0719--