Good evening,
Since phpng, int64, and perhaps other future changes in PHP 7 are a pretty big change, I think we ought to bump the major version number of the Zend Engine, from Zend Engine 2 to Zend Engine 3.
I have a pull request open which would do this, although it needs updating to correct extensions checking for ZEND_ENGINE_2: https://github.com/php/php-src/pull/829
Are there any objections to the idea? I realise work on the engine isn’t done, but that doesn’t mean we can’t name the new version. After all, we’ve named PHP 7, and it doesn’t exist yet, either.
Thoughts?
Andrea Faulds
http://ajf.me/
Hi!
Since phpng, int64, and perhaps other future changes in PHP 7 are a
pretty big change, I think we ought to bump the major version number
of the Zend Engine, from Zend Engine 2 to Zend Engine 3.
I agree, with all work on the engine being done, and new PHP major, I
think it makes sense to bump engine version too.
--
Stas Malyshev
smalyshev@gmail.com
Hey:
Good evening,
Since phpng, int64, and perhaps other future changes in PHP 7 are a pretty big change, I think we ought to bump the major version number of the Zend Engine, from Zend Engine 2 to Zend Engine 3.
I have a pull request open which would do this, although it needs updating to correct extensions checking for ZEND_ENGINE_2: https://github.com/php/php-src/pull/829
Are there any objections to the idea? I realise work on the engine isn’t done, but that doesn’t mean we can’t name the new version. After all, we’ve named PHP 7, and it doesn’t exist yet, either.
it's not objection!
what I was saying is, it must be done before 7 release cycle start.
then expose it for ext developers, we will do it in a proper
time(it's a small change, we can do in in anytime).
I can not guarantee engine won't change anymore, (like your bigint
patch or something else)...
I don't understand why you rush for it. any work of you depends the
number bumping?
after all, let me say again, no objection, but feel a little improper do it now
thanks
Thoughts?
Andrea Faulds
http://ajf.me/--
--
Xinchen Hui
@Laruence
http://www.laruence.com/
Hi!
I can not guarantee engine won't change anymore, (like your bigint
patch or something else)...
But having ZEND_ENGINE_3 is no guarantee it won't change anymore. It
just something that people can start to use now for changes that already
happened.
Stas Malyshev
smalyshev@gmail.com
2014-11-24 6:29 GMT+01:00 Xinchen Hui laruence@php.net:
I don't understand why you rush for it. any work of you depends the
number bumping?
I don't see what makes it so different that we cannot do it now
instead of later, not like it will be a game changer
+1 for the change
--
regards,
Kalle Sommer Nielsen
kalle@php.net
On Mon, Nov 24, 2014 at 10:24 AM, Kalle Sommer Nielsen kalle@php.net
wrote:
2014-11-24 6:29 GMT+01:00 Xinchen Hui laruence@php.net:
I don't understand why you rush for it. any work of you depends the
number bumping?I don't see what makes it so different that we cannot do it now
instead of later, not like it will be a game changer+1 for the change
+1, and given how Dmitry already bumped the other api versions used by the
ext developers (ZEND_MODULE_API_NO/ZEND_VERSION) I don't think that there
is any reason for us to be afraid to change it.
And bumping it early would actually give more time to the extension authors
to accommodate their code.
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
Good evening,
Since phpng, int64, and perhaps other future changes in PHP 7 are a pretty
big change, I think we ought to bump the major version number of the Zend
Engine, from Zend Engine 2 to Zend Engine 3.I have a pull request open which would do this, although it needs updating
to correct extensions checking for ZEND_ENGINE_2:
https://github.com/php/php-src/pull/829Are there any objections to the idea? I realise work on the engine isn’t
done, but that doesn’t mean we can’t name the new version. After all, we’ve
named PHP 7, and it doesn’t exist yet, either.Thoughts?
Why do we need this define at all? Imho extensions should be checking
against the API version, rather than a ZEND_ENGINE_N constant. This is more
precise (it's not like extension code stays the same between minor
versions), but the ZEND_ENGINE_N constant also has the problem that it
targets only 5.x, even though the code it guards would usually be relevant
to 7.x as well.
Nikita
Good evening,
Since phpng, int64, and perhaps other future changes in PHP 7 are a
pretty
big change, I think we ought to bump the major version number of the
Zend
Engine, from Zend Engine 2 to Zend Engine 3.I have a pull request open which would do this, although it needs
updating
to correct extensions checking for ZEND_ENGINE_2:
https://github.com/php/php-src/pull/829Are there any objections to the idea? I realise work on the engine isn’t
done, but that doesn’t mean we can’t name the new version. After all,
we’ve
named PHP 7, and it doesn’t exist yet, either.Thoughts?
Why do we need this define at all? Imho extensions should be checking
against the API version, rather than a ZEND_ENGINE_N constant. This is
more
precise (it's not like extension code stays the same between minor
versions), but the ZEND_ENGINE_N constant also has the problem that it
targets only 5.x, even though the code it guards would usually be relevant
to 7.x as well.
Paying to way for now asking someone to know the specific individual API
versions and their features, the convenience of saying "I know ZE 3
supports this and ZE2 does not" would be a worth while addition.
Especially for newcomers to ext dev.
Nikita
Good evening,
Since phpng, int64, and perhaps other future changes in PHP 7 are a
pretty
big change, I think we ought to bump the major version number of the
Zend
Engine, from Zend Engine 2 to Zend Engine 3.I have a pull request open which would do this, although it needs
updating
to correct extensions checking for ZEND_ENGINE_2:
https://github.com/php/php-src/pull/829Are there any objections to the idea? I realise work on the engine
isn’t
done, but that doesn’t mean we can’t name the new version. After all,
we’ve
named PHP 7, and it doesn’t exist yet, either.Thoughts?
Why do we need this define at all? Imho extensions should be checking
against the API version, rather than a ZEND_ENGINE_N constant. This is
more
precise (it's not like extension code stays the same between minor
versions), but the ZEND_ENGINE_N constant also has the problem that it
targets only 5.x, even though the code it guards would usually be
relevant
to 7.x as well.Paying to way for now asking someone to know the specific individual API
On my phone sorry. This should be: "Paving the way to not asking someone"
versions and their features, the convenience of saying "I know ZE 3
supports this and ZE2 does not" would be a worth while addition.
Especially for newcomers to ext dev.
Nikita
Good evening,
Since phpng, int64, and perhaps other future changes in PHP 7 are a pretty big change, I think we ought to bump the major version number of the Zend Engine, from Zend Engine 2 to Zend Engine 3.
I have a pull request open which would do this, although it needs updating to correct extensions checking for ZEND_ENGINE_2: https://github.com/php/php-src/pull/829
Are there any objections to the idea? I realise work on the engine isn’t done, but that doesn’t mean we can’t name the new version. After all, we’ve named PHP 7, and it doesn’t exist yet, either.
Some changes were made and reviewed, and the pull request has been merged.
PHP 7 shall ship with Zend Engine 3! \o/
https://github.com/php/php-src/commit/150dc69d6eee35738f505e925ee664c02060196d
Andrea Faulds
http://ajf.me/