Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79122
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c-BLeY8UJfENKuw-3c+c7naSrxbHA9hF+XYB06ctXFEzg@mail.gmail.com>
References: <47A69FC3-2DAF-492E-B780-F203211E531F@ajf.me>
	<CAF+90c-BLeY8UJfENKuw-3c+c7naSrxbHA9hF+XYB06ctXFEzg@mail.gmail.com>
Date: Mon, 24 Nov 2014 12:32:03 +0000
Message-ID: <CAKxcST-SyyAACx1Hx8AfJap_41tszC5qgGZ0d4-Fn9B-ti+Bmw@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>, Andrea Faulds <ajf@ajf.me>
Content-Type: multipart/alternative; boundary=001a11c360f861c0cf050899fb59
Subject: Re: [PHP-DEV] Zend Engine 3
From: dragoonis@gmail.com (Paul Dragoonis)

--001a11c360f861c0cf050899fb59
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 24 Nov 2014 12:18, "Nikita Popov" <nikita.ppv@gmail.com> wrote:
>
> On Mon, Nov 24, 2014 at 1:10 AM, Andrea Faulds <ajf@ajf.me> wrote:
>
> > Good evening,
> >
> > Since phpng, int64, and perhaps other future changes in PHP 7 are a
pretty
> > big change, I think we ought to bump the major version number of the
Zend
> > Engine, from Zend Engine 2 to Zend Engine 3.
> >
> > I have a pull request open which would do this, although it needs
updating
> > to correct extensions checking for ZEND_ENGINE_2:
> > https://github.com/php/php-src/pull/829
> >
> > Are there any objections to the idea? I realise work on the engine isn=
=E2=80=99t
> > done, but that doesn=E2=80=99t mean we can=E2=80=99t name the new versi=
on. After all,
we=E2=80=99ve
> > named PHP 7, and it doesn=E2=80=99t exist yet, either.
> >
> > Thoughts?
> >
>
> Why do we need this define at all? Imho extensions should be checking
> against the API version, rather than a ZEND_ENGINE_N constant. This is
more
> precise (it's not like extension code stays the same between minor
> versions), but the ZEND_ENGINE_N constant also has the problem that it
> targets only 5.x, even though the code it guards would usually be relevan=
t
> to 7.x as well.

Paying to way for now asking someone to know the specific individual API
versions and their features, the convenience of saying "I know ZE 3
supports this and ZE2 does not" would be a worth while addition.

Especially for newcomers to ext dev.

>
> Nikita

--001a11c360f861c0cf050899fb59--