Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:79121 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 45753 invoked from network); 24 Nov 2014 12:18:28 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Nov 2014 12:18:28 -0000 Authentication-Results: pb1.pair.com header.from=nikita.ppv@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.51 as permitted sender) X-PHP-List-Original-Sender: nikita.ppv@gmail.com X-Host-Fingerprint: 74.125.82.51 mail-wg0-f51.google.com Received: from [74.125.82.51] ([74.125.82.51:51330] helo=mail-wg0-f51.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BE/81-33396-21223745 for ; Mon, 24 Nov 2014 07:18:27 -0500 Received: by mail-wg0-f51.google.com with SMTP id k14so11886387wgh.38 for ; Mon, 24 Nov 2014 04:18:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=+nuW6URi7RwJj7Y7eqPlLd+pUKedALr4FcqnrfKkbpQ=; b=V7LMq7Y2Bi65w4mtuGefs5jQceuIO1UuZhDHaZgOtUsGaLSxwgwWpevIzmaM3DowlA LGL78L3dVrjmSRaTbgkv6H+hDFZb0MSZt1+B/lYqa/2+cenyU5tP6yXD5bYqvRMq/IZn 9pjUU9JGB4DTihwTUnA4oa680O0RPUu1cyMQpflv70yuHMwylaUwO5EWuVlfe6WlPz0O enmv6ivJPu4dL/PGJQNMBfxCIJgLEUD7gRtWQICqZ1CMAc54+404TR9Cw0ZF6uHEWaPB b0tggM3e5U/Z/CGNmpMZsOmsWltA+mtmajUBtx6icRJESepd6AdXarP7E3c4ujz08u7S aTmw== MIME-Version: 1.0 X-Received: by 10.180.78.73 with SMTP id z9mr20862812wiw.52.1416831502570; Mon, 24 Nov 2014 04:18:22 -0800 (PST) Received: by 10.27.10.4 with HTTP; Mon, 24 Nov 2014 04:18:22 -0800 (PST) In-Reply-To: <47A69FC3-2DAF-492E-B780-F203211E531F@ajf.me> References: <47A69FC3-2DAF-492E-B780-F203211E531F@ajf.me> Date: Mon, 24 Nov 2014 13:18:22 +0100 Message-ID: To: Andrea Faulds Cc: PHP Internals Content-Type: multipart/alternative; boundary=f46d0438903b6ad9c3050899ca1b Subject: Re: [PHP-DEV] Zend Engine 3 From: nikita.ppv@gmail.com (Nikita Popov) --f46d0438903b6ad9c3050899ca1b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, Nov 24, 2014 at 1:10 AM, Andrea Faulds wrote: > Good evening, > > Since phpng, int64, and perhaps other future changes in PHP 7 are a prett= y > big change, I think we ought to bump the major version number of the Zend > Engine, from Zend Engine 2 to Zend Engine 3. > > I have a pull request open which would do this, although it needs updatin= g > to correct extensions checking for ZEND_ENGINE_2: > https://github.com/php/php-src/pull/829 > > Are there any objections to the idea? I realise work on the engine isn=E2= =80=99t > done, but that doesn=E2=80=99t mean we can=E2=80=99t name the new version= . After all, we=E2=80=99ve > named PHP 7, and it doesn=E2=80=99t exist yet, either. > > Thoughts? > Why do we need this define at all? Imho extensions should be checking against the API version, rather than a ZEND_ENGINE_N constant. This is more precise (it's not like extension code stays the same between minor versions), but the ZEND_ENGINE_N constant also has the problem that it targets only 5.x, even though the code it guards would usually be relevant to 7.x as well. Nikita --f46d0438903b6ad9c3050899ca1b--