Hi internals,
I have created a PR to improve the base 2 and base 10 of the standard
math function "log" to reduce rounding errors.
Internally on log(x, 2) the native C function log2(x) and on log(x, 10)
the native C function log10(x) will be called.
The PR is open since april without any comments!
Please please please someone there to merge this.
PS:
Because of after this PR the following will be the same in PHP log10(x)
=== log10(x) the function log10 is needless and could be
deprecated/removed. I will create an RFC if this PR was merged.
Marc
forgotten the link:
https://github.com/php/php-src/pull/658
Hi internals,
I have created a PR to improve the base 2 and base 10 of the standard
math function "log" to reduce rounding errors.Internally on log(x, 2) the native C function log2(x) and on log(x, 10)
the native C function log10(x) will be called.The PR is open since april without any comments!
Please please please someone there to merge this.PS:
Because of after this PR the following will be the same in PHP log10(x)
=== log10(x) the function log10 is needless and could be
deprecated/removed. I will create an RFC if this PR was merged.Marc
forgotten the link:
https://github.com/php/php-src/pull/658Hi internals,
I have created a PR to improve the base 2 and base 10 of the standard
math function "log" to reduce rounding errors.Internally on log(x, 2) the native C function log2(x) and on log(x, 10)
the native C function log10(x) will be called.The PR is open since april without any comments!
Please please please someone there to merge this.PS:
Because of after this PR the following will be the same in PHP log10(x)
=== log10(x) the function log10 is needless and could be
deprecated/removed. I will create an RFC if this PR was merged.
This seems entirely reasonable and would be covered by existing unit
tests. No user-impacting effect (beyond being more precise/correct
output). I'll push this after my Dr appointment today if nobody has
beaten me to it.
-Sara
forgotten the link:
https://github.com/php/php-src/pull/658Hi internals,
I have created a PR to improve the base 2 and base 10 of the standard
math function "log" to reduce rounding errors.Internally on log(x, 2) the native C function log2(x) and on log(x, 10)
the native C function log10(x) will be called.The PR is open since april without any comments!
Please please please someone there to merge this.PS:
Because of after this PR the following will be the same in PHP log10(x)
=== log10(x) the function log10 is needless and could be
deprecated/removed. I will create an RFC if this PR was merged.This seems entirely reasonable and would be covered by existing unit
tests. No user-impacting effect (beyond being more precise/correct
output). I'll push this after my Dr appointment today if nobody has
beaten me to it.
Nice to see it's merged - thanks!
-Sara
Sara,
shouldn't it be merged into the branches PHP-5.4, PHP-5.5 as well as
PHP-5.6 and shouldn't there an info in the NEWS file? It's currently
only merged to master.
Marc
forgotten the link:
https://github.com/php/php-src/pull/658Hi internals,
I have created a PR to improve the base 2 and base 10 of the standard
math function "log" to reduce rounding errors.Internally on log(x, 2) the native C function log2(x) and on log(x, 10)
the native C function log10(x) will be called.The PR is open since april without any comments!
Please please please someone there to merge this.PS:
Because of after this PR the following will be the same in PHP log10(x)
=== log10(x) the function log10 is needless and could be
deprecated/removed. I will create an RFC if this PR was merged.This seems entirely reasonable and would be covered by existing unit
tests. No user-impacting effect (beyond being more precise/correct
output). I'll push this after my Dr appointment today if nobody has
beaten me to it.-Sara
Sara,
shouldn't it be merged into the branches PHP-5.4, PHP-5.5 as well as
PHP-5.6 and shouldn't there an info in the NEWS file? It's currently
only merged to master.Marc
There might be an argument against adding to 5.4 and 5.5 in that code may now give slightly different results from before, and it’s not really a bugfix as there was no bug.
Andrea Faulds
http://ajf.me/
shouldn't it be merged into the branches PHP-5.4, PHP-5.5 as well as
PHP-5.6 and shouldn't there an info in the NEWS file? It's currently
only merged to master.
I opted for master-only on the grounds that while it's an improvement,
it's not really a bugfix, and released versions (or versions as near
to release as 5.6 is) should be bug-fix only. I know there's an
argument for this being a bug-fix, but...
If a consensus feels it should be merged back I won't object.
-Sara
Hi!
I opted for master-only on the grounds that while it's an improvement,
it's not really a bugfix, and released versions (or versions as near
to release as 5.6 is) should be bug-fix only. I know there's an
argument for this being a bug-fix, but...If a consensus feels it should be merged back I won't object.
I think we can have it in 5.6 and 5.5. 5.4 being very close to
security-only (with the switch technically being already past due) I'd
not merge something that works without the fix back there.
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
Hi!
I opted for master-only on the grounds that while it's an improvement,
it's not really a bugfix, and released versions (or versions as near
to release as 5.6 is) should be bug-fix only. I know there's an
argument for this being a bug-fix, but...If a consensus feels it should be merged back I won't object.
I think we can have it in 5.6 and 5.5. 5.4 being very close to
security-only (with the switch technically being already past due) I'd
not merge something that works without the fix back there.
5.5 and 5.6 would be very OK for me :)