Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76518
Return-Path: <php@golemon.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 91309 invoked from network); 14 Aug 2014 15:29:18 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 14 Aug 2014 15:29:18 -0000
Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail
Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.220.49 as permitted sender)
X-PHP-List-Original-Sender: php@golemon.com
X-Host-Fingerprint: 209.85.220.49 mail-pa0-f49.google.com  
Received: from [209.85.220.49] ([209.85.220.49:47967] helo=mail-pa0-f49.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 47/A8-40673-CC5DCE35 for <internals@lists.php.net>; Thu, 14 Aug 2014 11:29:17 -0400
Received: by mail-pa0-f49.google.com with SMTP id hz1so1796134pad.8
        for <internals@lists.php.net>; Thu, 14 Aug 2014 08:29:13 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:sender:in-reply-to:references:date
         :message-id:subject:from:to:cc:content-type;
        bh=29uV6JxfZNsUfqQPlneqbhm2KEDZz0SCwdVe3Jadnaw=;
        b=aNEdqmZS7iW1k3a2jdEWCpp9xuIR8jmNGboUlXH3XnrrSbszyNRQFUffH2uZtfSntt
         IFO3aPLccQYF+AIkIm2ASusrHJSj5etBlXOua7bwMXXJFLvzTf10XItvPm2aWLsAu88V
         FVec7rNYNrzuKehuFvOw/QSp+QwfmRhyeDrfpYIOL23gzqljwSIzcIUUesdIxW1vnPQc
         ZFBD28eTqJOmegXu081pQZCv0lVzMYLAL7Ep0HqScjGmbTXzAN6HjPZZOYSa5wRERjN2
         3Ck1xIgEHvynBqvbQwvOK0qXahmVgJ20s7B8OvnnxY7+6DFKkOOmBTTXomjxXozUJrs8
         4UDA==
X-Gm-Message-State: ALoCoQnPETLznRBqViztxS6inUQBvuxpEWSp60120dbU2C5KGsjof3iVv8wpmGNQtOXi0cOq99ql
MIME-Version: 1.0
X-Received: by 10.70.55.199 with SMTP id u7mr10927298pdp.136.1408030153405;
 Thu, 14 Aug 2014 08:29:13 -0700 (PDT)
Sender: php@golemon.com
Received: by 10.70.95.37 with HTTP; Thu, 14 Aug 2014 08:29:13 -0700 (PDT)
X-Originating-IP: [69.63.185.56]
In-Reply-To: <53EC8507.9020303@mabe.berlin>
References: <53EC84BF.9000002@mabe.berlin>
	<53EC8507.9020303@mabe.berlin>
Date: Thu, 14 Aug 2014 08:29:13 -0700
X-Google-Sender-Auth: L115r8Kx7zYGxIfvZA5CLk0GqxI
Message-ID: <CAESVnVr6UWiWnCcfOvFC+yYgAiCEJZHiNWtpwxWXsTORynwKcw@mail.gmail.com>
To: Marc Bennewitz <php@mabe.berlin>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Improved logarithm of base 2|10 of standard math function
From: pollita@php.net (Sara Golemon)

On Thu, Aug 14, 2014 at 2:44 AM, Marc Bennewitz <php@mabe.berlin> wrote:
> forgotten the link:
> https://github.com/php/php-src/pull/658
>
>
> On 14.08.2014 11:43, Marc Bennewitz wrote:
>>
>> Hi internals,
>>
>> I have created a PR to improve the base 2 and base 10 of the standard
>> math function "log" to reduce rounding errors.
>>
>> Internally on log(x, 2) the native C function log2(x) and on log(x, 10)
>> the native C function log10(x) will be called.
>>
>> The PR is open since april without any comments!
>> Please please please someone there to merge this.
>>
>> PS:
>> Because of after this PR the following will be the same in PHP log10(x)
>> === log10(x) the function log10 is needless and could be
>> deprecated/removed. I will create an RFC if this PR was merged.
>>
>
This seems entirely reasonable and would be covered by existing unit
tests.   No user-impacting effect (beyond being more precise/correct
output).  I'll push this after my Dr appointment today if nobody has
beaten me to it.

-Sara