Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76522
Return-Path: <php@mabe.berlin>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 5066 invoked from network); 14 Aug 2014 17:47:10 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 14 Aug 2014 17:47:10 -0000
Authentication-Results: pb1.pair.com header.from=php@mabe.berlin; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=php@mabe.berlin; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain mabe.berlin from 80.237.132.171 cause and error)
X-PHP-List-Original-Sender: php@mabe.berlin
X-Host-Fingerprint: 80.237.132.171 wp164.webpack.hosteurope.de  
Received: from [80.237.132.171] ([80.237.132.171:37453] helo=wp164.webpack.hosteurope.de)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id BF/9A-40673-D16FCE35 for <internals@lists.php.net>; Thu, 14 Aug 2014 13:47:10 -0400
Received: from dslb-178-005-089-244.178.005.pools.vodafone-ip.de ([178.5.89.244] helo=[192.168.178.30]); authenticated
	by wp164.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	id 1XHz7B-0001LG-IY; Thu, 14 Aug 2014 19:47:05 +0200
Message-ID: <53ECF618.1010100@mabe.berlin>
Date: Thu, 14 Aug 2014 19:47:04 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Sara Golemon <pollita@php.net>
CC: PHP internals <internals@lists.php.net>
References: <53EC84BF.9000002@mabe.berlin>	<53EC8507.9020303@mabe.berlin> <CAESVnVr6UWiWnCcfOvFC+yYgAiCEJZHiNWtpwxWXsTORynwKcw@mail.gmail.com>
In-Reply-To: <CAESVnVr6UWiWnCcfOvFC+yYgAiCEJZHiNWtpwxWXsTORynwKcw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-bounce-key: webpack.hosteurope.de;php@mabe.berlin;1408038430;aecda11b;
Subject: Re: [PHP-DEV] Improved logarithm of base 2|10 of standard math function
From: php@mabe.berlin (Marc Bennewitz)

On 14.08.2014 17:29, Sara Golemon wrote:
> On Thu, Aug 14, 2014 at 2:44 AM, Marc Bennewitz <php@mabe.berlin> wrote:
>> forgotten the link:
>> https://github.com/php/php-src/pull/658
>>
>>
>> On 14.08.2014 11:43, Marc Bennewitz wrote:
>>>
>>> Hi internals,
>>>
>>> I have created a PR to improve the base 2 and base 10 of the standard
>>> math function "log" to reduce rounding errors.
>>>
>>> Internally on log(x, 2) the native C function log2(x) and on log(x, 10)
>>> the native C function log10(x) will be called.
>>>
>>> The PR is open since april without any comments!
>>> Please please please someone there to merge this.
>>>
>>> PS:
>>> Because of after this PR the following will be the same in PHP log10(x)
>>> === log10(x) the function log10 is needless and could be
>>> deprecated/removed. I will create an RFC if this PR was merged.
>>>
>>
> This seems entirely reasonable and would be covered by existing unit
> tests.   No user-impacting effect (beyond being more precise/correct
> output).  I'll push this after my Dr appointment today if nobody has
> beaten me to it.

Nice to see it's merged - thanks!

> 
> -Sara
>