https://github.com/php/php-src/pull/674
It fixes bug 66622: https://bugs.php.net/bug.php?id=66622
I've prodded people on #php.pecl and nobody has had any complaints
about it, so I don't anticipate any issues; if there is an issue do
let me know.
Hi!
https://github.com/php/php-src/pull/674
It fixes bug 66622: https://bugs.php.net/bug.php?id=66622
I've prodded people on #php.pecl and nobody has had any complaints
Didn't we just has a discussion about it an hour ago?
about it, so I don't anticipate any issues; if there is an issue do
let me know.
I still don't think we should move the tests around.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
Hi!
https://github.com/php/php-src/pull/674
It fixes bug 66622: https://bugs.php.net/bug.php?id=66622
I've prodded people on #php.pecl and nobody has had any complaintsDidn't we just has a discussion about it an hour ago?
No, you mentioned one tiny thing that isn't really about the bug fix.
That's hardly a conversation.
about it, so I don't anticipate any issues; if there is an issue do
let me know.I still don't think we should move the tests around.
I disagree but it is a minor point. Others have said it makes sense to
put related tests in a folder in IRC.
I don't really care; you can easily not apply those changes.
I don't really care; you can easily not apply those changes.
To clarify, those changes are in a separate commit so that's why it
would be easy to not apply them.
Hi!
https://github.com/php/php-src/pull/674
It fixes bug 66622: https://bugs.php.net/bug.php?id=66622
I've prodded people on #php.pecl and nobody has had any complaintsDidn't we just has a discussion about it an hour ago?
about it, so I don't anticipate any issues; if there is an issue do
let me know.I still don't think we should move the tests around.
I've rebased the PR to not change the phpt locations even though I
think they are better in a subdirectory.
A local make test
shows nothing has been broken; Travis CI will
hopefully confirm the same in a bit.