Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74790
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.43 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <5394F84E.9040300@sugarcrm.com>
References: <CAFMT4NqUe7A7bxgyVmNkexjS-yTYmbEsJBrP_3H2SE48SvV=Xw@mail.gmail.com>
	<5394F84E.9040300@sugarcrm.com>
Date: Sun, 8 Jun 2014 19:41:07 -0600
Message-ID: <CAFMT4Not3gQssy5eUYyBy6r8DPQCgbESS+2Gg9m0arhjQri7XQ@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Can someone with Zend karma please merge PR #674?
From: levim@php.net (Levi Morrison)

On Sun, Jun 8, 2014 at 5:57 PM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
>> https://github.com/php/php-src/pull/674
>>
>> It fixes bug 66622: https://bugs.php.net/bug.php?id=66622
>> I've prodded people on #php.pecl and nobody has had any complaints
>
> Didn't we just has a discussion about it an hour ago?
>
>> about it, so I don't anticipate any issues; if there is an issue do
>> let me know.
>
> I still don't think we should move the tests around.

I've rebased the PR to not change the phpt locations even though I
think they are better in a subdirectory.

A local `make test` shows nothing has been broken; Travis CI will
hopefully confirm the same in a bit.