Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74787
Return-Path: <morrison.levi@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 13227 invoked from network); 9 Jun 2014 00:05:55 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 9 Jun 2014 00:05:55 -0000
Authentication-Results: pb1.pair.com smtp.mail=morrison.levi@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=morrison.levi@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.51 as permitted sender)
X-PHP-List-Original-Sender: morrison.levi@gmail.com
X-Host-Fingerprint: 209.85.219.51 mail-oa0-f51.google.com  
Received: from [209.85.219.51] ([209.85.219.51:38830] helo=mail-oa0-f51.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id B4/96-12959-16AF4935 for <internals@lists.php.net>; Sun, 08 Jun 2014 20:05:53 -0400
Received: by mail-oa0-f51.google.com with SMTP id j17so1586122oag.24
        for <internals@lists.php.net>; Sun, 08 Jun 2014 17:05:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:date:message-id:subject
         :from:to:cc:content-type;
        bh=xP/ot5DQ5flRygUD/KRYbFhPkLsD5FUk5ZsWmBGkONI=;
        b=lBdtudBR8NE57eEjByzdXbXNy0QilCBtjiZ6zt8KRt3aWiUk0p4zJ/7sadArTe1c4I
         98chN7cvTwp+lFEEZh49iHkWxJwSSLVsLB3CdPG1sRTW86mr1pp+fmJtUSDxJCel0n7C
         evPKsF8A9IeEVNOhQYZQVzxOUTgeFsd+ukv/Uh7jHNeBRHB29RQ6ia1SHaikLsDdsc+S
         TCj8NFVrReqodD/EDfg4rE5jqoa1ltxXfGyCeg64T+KAKGXdxkxawp+QbNOAfaFZfE9w
         9oWsPBD2x9u+mL6BviHUtUDF5aPri35JovcSx3IdH1hUe8lb60Ok8jeCvVjx4ooTQpoG
         Wydw==
MIME-Version: 1.0
X-Received: by 10.60.178.243 with SMTP id db19mr22670194oec.11.1402272350523;
 Sun, 08 Jun 2014 17:05:50 -0700 (PDT)
Sender: morrison.levi@gmail.com
Received: by 10.76.77.100 with HTTP; Sun, 8 Jun 2014 17:05:50 -0700 (PDT)
In-Reply-To: <5394F84E.9040300@sugarcrm.com>
References: <CAFMT4NqUe7A7bxgyVmNkexjS-yTYmbEsJBrP_3H2SE48SvV=Xw@mail.gmail.com>
	<5394F84E.9040300@sugarcrm.com>
Date: Sun, 8 Jun 2014 18:05:50 -0600
X-Google-Sender-Auth: qjQHVwJW-1Dq0o0XbM4xN1AqYAU
Message-ID: <CAFMT4NpASH_+ADy2NCOBteNZTEvLpL1WTqq63gpEeUp8tXzyQw@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Can someone with Zend karma please merge PR #674?
From: levim@php.net (Levi Morrison)

On Sun, Jun 8, 2014 at 5:57 PM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
>> https://github.com/php/php-src/pull/674
>>
>> It fixes bug 66622: https://bugs.php.net/bug.php?id=66622
>> I've prodded people on #php.pecl and nobody has had any complaints
>
> Didn't we just has a discussion about it an hour ago?

No, you mentioned one tiny thing that isn't really about the bug fix.
That's hardly a conversation.

>> about it, so I don't anticipate any issues; if there is an issue do
>> let me know.
>
> I still don't think we should move the tests around.

I disagree but it is a minor point. Others have said it makes sense to
put related tests in a folder in IRC.

I don't really care; you can easily not apply those changes.