Status of pull request View as Markdown

Thanks! It simply implements native support for creating, parsing &
exporting details of SPKAC strings sent from browsers using the HTML5
KeyGen element (even though the element has been around since Netscape 1 or
2).

Hi Jason,

thanks for the reminder.

Am 13.02.2013 um 14:03 schrieb Jason Gerfen jason.gerfen@gmail.com:

Is it considered spamming the list to check the status of a pull
request? I
am going to ask any ways, hope it doesn't offend.

The pull request addresses bug fix/feature request #38917 implementing
native signed public key & challenge support to the OpenSSL extension.
Details can be found @ https://github.com/php/php-src/pull/267

(I created a new branch 'issue-38917-spkac' according to the Wiki, but
does
not seem to be in the list of branches anylonger)

I'm personally don't feel comfortable enough to mess around in
ext/openssl. Could somebody else please have a look?

cu,
Lars

--
Jason Gerfen
jason.gerfen@gmail.com

http://www.github.com/jas-
http://dev.in-my-cloud.com/pow-mia
http://in-my-cloud.com
http://awesomealaskaadventures.com
http://phpdhcpadmin.sourceforge.net

Thanks, for whatever reason it caught the pbkdf2 stuff, not intensional.

I will update it asap

Jas

Hi!

The pull request addresses bug fix/feature request #38917 implementing
native signed public key & challenge support to the OpenSSL extension.
Details can be found @ https://github.com/php/php-src/pull/267

I've looked into it and two things are missing:

1. Failure scenario tests. See my comments on the patch, in many
   functions initializations are missing and error scenarios segfault.
   Please fix it.

2. For some reason the diff includes pbkdf2 which is not part of the
   patch. No idea why. Could you clean it up?

If this is done, we could get it into 5.5 probably.

Thanks,

--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227