Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:65900
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.174 as permitted sender)
References: <CAMU2igubbfdF7Jq5c6YO1G4kM2m06c00F=Ua7cVZ_FL68hf8VA@mail.gmail.com> <5120AD08.1030301@sugarcrm.com>
Mime-Version: 1.0 (1.0)
In-Reply-To: <5120AD08.1030301@sugarcrm.com>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <364C1140-CB09-4043-90E7-6C763789FC45@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Date: Sun, 17 Feb 2013 08:40:48 -0700
To: Stas Malyshev <smalyshev@sugarcrm.com>
Subject: Re: [PHP-DEV] Status of pull request
From: jason.gerfen@gmail.com ("jason.gerfen@gmail.com")

Thanks, for whatever reason it caught the pbkdf2 stuff, not intensional.

I will update it asap

Jas

On Feb 17, 2013, at 3:12 AM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:

> Hi!
> 
>> The pull request addresses bug fix/feature request #38917 implementing
>> native signed public key & challenge support to the OpenSSL extension.
>> Details can be found @ https://github.com/php/php-src/pull/267
> 
> I've looked into it and two things are missing:
> 1. Failure scenario tests. See my comments on the patch, in many
> functions initializations are missing and error scenarios segfault.
> Please fix it.
> 
> 2. For some reason the diff includes pbkdf2 which is not part of the
> patch. No idea why. Could you clean it up?
> 
> If this is done, we could get it into 5.5 probably.
> 
> Thanks,
> 
> -- 
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227