Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:65896 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 74997 invoked from network); 17 Feb 2013 10:12:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 Feb 2013 10:12:30 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.133 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 67.192.241.133 smtp133.dfw.emailsrvr.com Linux 2.6 Received: from [67.192.241.133] ([67.192.241.133:53758] helo=smtp133.dfw.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CE/F0-65378-C0DA0215 for ; Sun, 17 Feb 2013 05:12:29 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp13.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id DE2713D0475; Sun, 17 Feb 2013 05:12:25 -0500 (EST) X-Virus-Scanned: OK Received: by smtp13.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 532803D046D; Sun, 17 Feb 2013 05:12:25 -0500 (EST) Message-ID: <5120AD08.1030301@sugarcrm.com> Date: Sun, 17 Feb 2013 02:12:24 -0800 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Jason Gerfen CC: "internals@lists.php.net" References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Status of pull request From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > The pull request addresses bug fix/feature request #38917 implementing > native signed public key & challenge support to the OpenSSL extension. > Details can be found @ https://github.com/php/php-src/pull/267 I've looked into it and two things are missing: 1. Failure scenario tests. See my comments on the patch, in many functions initializations are missing and error scenarios segfault. Please fix it. 2. For some reason the diff includes pbkdf2 which is not part of the patch. No idea why. Could you clean it up? If this is done, we could get it into 5.5 probably. Thanks, -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227