[proposal + pull request] Replace logo GUIDs with data URIs

FYI, data URIs are only supported in IE8 or higher, IE7 and below do not
support them.

Hi there,

This is a patch that replaces PHP's infamous logo GUIDs with data URIs
instead, and also embed PHP credits in the phpinfo() page, hidden
using JavaScript (but gracefully degrading), to eliminate these GUIDs
altogether.

:)

https://github.com/php/php-src/pull/132

Looks ok to me. master-only, of course. It is simpler and cleaner than
the GUID approach and I think enough browsers can handle data URIs these
days.

-Rasmus

--

--
Brandon Wamboldt
Programmer / Web Developer

StackOverflow Careers
Profilehttp://careers.stackoverflow.com/brandonwamboldt- GitHub
Profile https://github.com/brandonwamboldt -
LinkedInhttps://github.com/brandonwamboldt -
My Blog <http://brandonwamboldt.ca/

Hi!

And I actually know of websites using the functions to display the logo..
Is there some way we could provide a BC function for it somehow?
Maybe rather then removing the functions, make then return the data uris?

Having the functions to get the images sounds like a good idea, some
sites may want to use them to display the logos. However, I don't think
we should use the same function, as then deciding what the function
actually does is complicated. I'd rather prefer doing something like:

if(function_exists('php_logo_guid')) {
$url = "/index.php?=".php_logo_guid();
} else if(function_exists('php_logo_url')) {
$url = php_logo_url();
}
if(!empty($url))
echo "<img src="$url" alt="php logo">";

it's clear what each function gives me then.

--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227