Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61238
Return-Path: <smalyshev@sugarcrm.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 98753 invoked from network); 14 Jul 2012 21:49:03 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 14 Jul 2012 21:49:03 -0000
Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.153 as permitted sender)
X-PHP-List-Original-Sender: smalyshev@sugarcrm.com
X-Host-Fingerprint: 67.192.241.153 smtp153.dfw.emailsrvr.com Linux 2.6
Received: from [67.192.241.153] ([67.192.241.153:48837] helo=smtp153.dfw.emailsrvr.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 3E/31-20866-D49E1005 for <internals@lists.php.net>; Sat, 14 Jul 2012 17:49:03 -0400
Received: from localhost (localhost.localdomain [127.0.0.1])
	by smtp5.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id 0904F586F0;
	Sat, 14 Jul 2012 17:48:59 -0400 (EDT)
X-Virus-Scanned: OK
Received: by smtp5.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 9B2CA583B1;
	Sat, 14 Jul 2012 17:48:58 -0400 (EDT)
Message-ID: <5001E949.50407@sugarcrm.com>
Date: Sat, 14 Jul 2012 14:48:57 -0700
Organization: SugarCRM
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20120614 Thunderbird/13.0.1
MIME-Version: 1.0
To: Hannes Magnusson <hannes.magnusson@gmail.com>
CC: Andrew Faulds <ajfweb@googlemail.com>, 
 internals <internals@lists.php.net>
References: <CAN+gjSeHqv+fXcs7zY-TW+v9UdUWKKyntzZpaVGunrOoZgvpkQ@mail.gmail.com> <CADNQb0WgWfXisG8L6mLz5MnYv2Cdmjyo+C+nycvY3eNxSXq-XQ@mail.gmail.com>
In-Reply-To: <CADNQb0WgWfXisG8L6mLz5MnYv2Cdmjyo+C+nycvY3eNxSXq-XQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [proposal + pull request] Replace logo GUIDs with data
 URIs
From: smalyshev@sugarcrm.com (Stas Malyshev)

Hi!

> And I actually know of websites using the functions to display the logo..
> Is there some way we could provide a BC function for it somehow?
> Maybe rather then removing the functions, make then return the data uris?

Having the functions to get the images sounds like a good idea, some
sites may want to use them to display the logos. However, I don't think
we should use the same function, as then deciding what the function
actually does is complicated. I'd rather prefer doing something like:

if(function_exists('php_logo_guid')) {
  $url = "/index.php?=".php_logo_guid();
} else if(function_exists('php_logo_url')) {
  $url = php_logo_url();
}
if(!empty($url))
echo "<img src=\"$url\" alt=\"php logo\">";

it's clear what each function gives me then.

-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227