Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61278
Return-Path: <nikita.ppv@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 49857 invoked from network); 16 Jul 2012 09:24:11 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 16 Jul 2012 09:24:11 -0000
Authentication-Results: pb1.pair.com header.from=nikita.ppv@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.170 as permitted sender)
X-PHP-List-Original-Sender: nikita.ppv@gmail.com
X-Host-Fingerprint: 209.85.217.170 mail-lb0-f170.google.com  
Received: from [209.85.217.170] ([209.85.217.170:51249] helo=mail-lb0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 63/68-20866-ABDD3005 for <internals@lists.php.net>; Mon, 16 Jul 2012 05:24:11 -0400
Received: by lbgc1 with SMTP id c1so8131712lbg.29
        for <internals@lists.php.net>; Mon, 16 Jul 2012 02:24:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=KNOFF4UtGgOolaC0IYw516bx7M4NFCd4nT5anQN83+c=;
        b=vteGrDI78LkZh42Jl7Xf0eb7RyUmDZInn8ETcNd+GQu7KrLj7ZvLlfyaTbRniGk1lG
         55lLM+I1OF7NminHjAsHtFhb2en+CIb7LOJvLGcrsBugv0uqjFo3cB5oOWCm5PfBhtRk
         1sJnD6aiLTEQJZyML9gMJYo/3Cx+DDTk1w0CL18CHNc4T7MhZgGsYjV+uaXr8gr1Nofa
         qIVitSpI5O+O8Xl8djEV6933fnzFqZIsZKth3aHjGaSB2YZmnoON2YM2OLjco3SUQBMW
         IPho6L2NhBKQr9HSzAozUEJN2+qXSrCWcgGEtE5q22XSoqJ30qQmGJ/RtEXdplgrkwig
         XJpw==
MIME-Version: 1.0
Received: by 10.152.106.233 with SMTP id gx9mr10731356lab.48.1342430647306;
 Mon, 16 Jul 2012 02:24:07 -0700 (PDT)
Received: by 10.152.114.70 with HTTP; Mon, 16 Jul 2012 02:24:07 -0700 (PDT)
In-Reply-To: <5001E949.50407@sugarcrm.com>
References: <CAN+gjSeHqv+fXcs7zY-TW+v9UdUWKKyntzZpaVGunrOoZgvpkQ@mail.gmail.com>
	<CADNQb0WgWfXisG8L6mLz5MnYv2Cdmjyo+C+nycvY3eNxSXq-XQ@mail.gmail.com>
	<5001E949.50407@sugarcrm.com>
Date: Mon, 16 Jul 2012 11:24:07 +0200
Message-ID: <CAF+90c81ewx1zVzUP2Tt2OX85v0iR5sDMe2r_v5geNUtbf+oQQ@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: Hannes Magnusson <hannes.magnusson@gmail.com>, Andrew Faulds <ajfweb@googlemail.com>, 
	internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [proposal + pull request] Replace logo GUIDs with data URIs
From: nikita.ppv@gmail.com (Nikita Popov)

On Sat, Jul 14, 2012 at 11:48 PM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Having the functions to get the images sounds like a good idea, some
> sites may want to use them to display the logos. However, I don't think
> we should use the same function, as then deciding what the function
> actually does is complicated. I'd rather prefer doing something like:
>
> if(function_exists('php_logo_guid')) {
>   $url = "/index.php?=".php_logo_guid();
> } else if(function_exists('php_logo_url')) {
>   $url = php_logo_url();
> }
> if(!empty($url))
> echo "<img src=\"$url\" alt=\"php logo\">";
>
> it's clear what each function gives me then.
I don't think that this is really necessary. If you want to use the
PHP logo, just embed it into your website using some URL. We don't
need to provide data: URLs for that.

Besides, adding a new function and removing the old one would require
application changes for the people who used the GUIDs. And in that
case it doesn't make much of a difference whether they switch to using
data: URLs provided by yet another function or whether they just use a
normal URL to a PHP logo.

So +1 on removing GUIDs, -1 on adding new functions.

Nikita