Going through the 26 open pull requests (please let us work on getting
that number down), I stumbled over https://github.com/php/php-src/pull/60.
This was already proposed on the mailinglits, but the thread died fast without
a satisfying answer on whether to add a function boolval() or not.
Personally I would like to see the function in. Having a complete set
of XYZval() functions is a good reason for me to add that function. The
implementation is simple and straight forward and easy to maintain.
Do we need an RFC for that simple pull request or can we just go ahead
and pull it?
David
Hi!
Going through the 26 open pull requests (please let us work on getting
that number down), I stumbled over https://github.com/php/php-src/pull/60.This was already proposed on the mailinglits, but the thread died fast without
a satisfying answer on whether to add a functionboolval()or not.
I think boolval() is fine, but implementation seems to be overly
complicated - why not just use zend_is_true?
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
David Soria Parra dsp@php.net wrote:
Going through the 26 open pull requests (please let us work on getting
that number down), I stumbled over
https://github.com/php/php-src/pull/60.This was already proposed on the mailinglits, but the thread died fast
without
a satisfying answer on whether to add a functionboolval()or not.Personally I would like to see the function in. Having a complete set
of XYZval() functions is a good reason for me to add that function.
The
implementation is simple and straight forward and easy to maintain.Do we need an RFC for that simple pull request or can we just go ahead
and pull it?
Pull it.
Derick
hi,
Pull it but I would still do a RFC to clearly document it (exact
behaviors), which could be then used by the doc team and to implement
tests.
David Soria Parra dsp@php.net wrote:
Going through the 26 open pull requests (please let us work on getting
that number down), I stumbled over
https://github.com/php/php-src/pull/60.This was already proposed on the mailinglits, but the thread died fast
without
a satisfying answer on whether to add a functionboolval()or not.Personally I would like to see the function in. Having a complete set
of XYZval() functions is a good reason for me to add that function.
The
implementation is simple and straight forward and easy to maintain.Do we need an RFC for that simple pull request or can we just go ahead
and pull it?
Pull it.Derick
--
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org
Hi,
2012/6/6 Pierre Joye pierre.php@gmail.com:
hi,
Pull it but I would still do a RFC to clearly document it (exact
behaviors), which could be then used by the doc team and to implement
tests.David Soria Parra dsp@php.net wrote:
Going through the 26 open pull requests (please let us work on getting
that number down), I stumbled over
https://github.com/php/php-src/pull/60.This was already proposed on the mailinglits, but the thread died fast
without
a satisfying answer on whether to add a functionboolval()or not.Personally I would like to see the function in. Having a complete set
of XYZval() functions is a good reason for me to add that function.
The
implementation is simple and straight forward and easy to maintain.Do we need an RFC for that simple pull request or can we just go ahead
and pull it?
Pull it.Derick
--
Pull it! About the RFC, I think isn't necessary as the behavior is
obvious, i.e. it behaves like a cast to bool.
--
Regards,
Felipe Pena
Hi,
2012/6/6 Pierre Joye pierre.php@gmail.com:
hi,
Pull it but I would still do a RFC to clearly document it (exact
behaviors), which could be then used by the doc team and to implement
tests.David Soria Parra dsp@php.net wrote:
Going through the 26 open pull requests (please let us work on getting
that number down), I stumbled over
https://github.com/php/php-src/pull/60.This was already proposed on the mailinglits, but the thread died fast
without
a satisfying answer on whether to add a functionboolval()or not.Personally I would like to see the function in. Having a complete set
of XYZval() functions is a good reason for me to add that function.
The
implementation is simple and straight forward and easy to maintain.Do we need an RFC for that simple pull request or can we just go ahead
and pull it?
Pull it.Derick
--
Pull it! About the RFC, I think isn't necessary as the behavior is
obvious, i.e. it behaves like a cast to bool.--
Regards,
Felipe Pena--
IMHO since it represents a language change (albeit a minor one) I agree
with Pierre that an RFC wouldn't hurt. If nothing else it's just a good
habit to get into I think.
--Kris
On Wed, 06 Jun 2012 21:40:54 +0200, Kris Craig kris.craig@gmail.com
wrote:
IMHO since it represents a language change (albeit a minor one) I agree
with Pierre that an RFC wouldn't hurt. If nothing else it's just a good
habit to get into I think.
Adding a function or class most definitely is not a language change
(unless they have some special treatment like Iterator), unless you
consider all the core functions and classes to be part of the language, at
which point everything is a language change.
An RFC for such a trivial change is an utter waste of time IMO.
--
Gustavo Lopes
hi Gustavo,
Adding a function or class most definitely is not a language change (unless
they have some special treatment like Iterator), unless you consider all the
core functions and classes to be part of the language, at which point
everything is a language change.
boolval like other type related functions are not languages constructs
per se but parts of the very core of PHP, so same treatment applies.
An RFC for such a trivial change is an utter waste of time IMO.
I would not say waste of time, but for the long term record and
clarity, a RFC should always be written, no matter how short (i.e.
boolval) or long (i.e. intl additions) it is.
Cheers,
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org
Do we need an RFC for that simple pull request or can we just go ahead
and pull it?
Please don't waste your time on an rfc for it. If you really want to write
anything, write the doc.
-Hannes