Hi:
recently I was working on PHP bugs.
and submit 3 patches,
#36944 strncmp & negative len https://bugs.php.net/bug.php?id=36944
#54556 array access to empty var does not trigger a notice
https://bugs.php.net/bug.php?id=54556
#55211 ArrayObject::getArrayObject () should skip proteced or
private properties https://bugs.php.net/bug.php?id=55211
someone plz verify them. thanks
and by the way, can I earn svn karma for PHP src now?
I also submitted
#54347 reflection_extension does not lowercase module function name
#52935 call exit in user_error_handler cause stream relate core
and one rfc:
https://wiki.php.net/rfc/foreachlist
and one pecl:
http://pecl.php.net/package/Yaf
if the karma approved, I promise I will work harder, and observe
all existing rules.
but it's okey if that you think I am not ready for a PHP src karma,
we can talk this later. :)
thanks
--
Laruence Xinchen Hui
http://www.laruence.com/
Hi:
new patch:
#55128 SplFixedArray::fromArray() does not use extended class
thanks
2011/7/25 Laruence laruence@php.net:
Hi:
recently I was working on PHP bugs.and submit 3 patches,
#36944 strncmp & negative len https://bugs.php.net/bug.php?id=36944
#54556 array access to empty var does not trigger a notice
https://bugs.php.net/bug.php?id=54556
#55211 ArrayObject::getArrayObject () should skip proteced or
private properties https://bugs.php.net/bug.php?id=55211someone plz verify them. thanks
and by the way, can I earn svn karma for PHP src now?
I also submitted
#54347 reflection_extension does not lowercase module function name
#52935 call exit in user_error_handler cause stream relate coreand one rfc:
https://wiki.php.net/rfc/foreachlistand one pecl:
http://pecl.php.net/package/Yafif the karma approved, I promise I will work harder, and observe
all existing rules.but it's okey if that you think I am not ready for a PHP src karma,
we can talk this later. :)thanks
--
Laruence Xinchen Hui
http://www.laruence.com/
--
Laruence Xinchen Hui
http://www.laruence.com/
Em Tue, 26 Jul 2011 06:42:50 +0100, Laruence laruence@php.net escreveu:
2011/7/25 Laruence laruence@php.net:
Hi:
recently I was working on PHP bugs.and submit 3 patches,
#36944 strncmp & negative len
https://bugs.php.net/bug.php?id=36944
Looks good, but I didn't got through it thoroughly to check the
consistency of the signs.
#54556 array access to empty var does not trigger a notice
https://bugs.php.net/bug.php?id=54556
Won't this be affected?
<?php
$foo[] = 'bar';
I don't see a good reason for this not to be allowed.
#55211 ArrayObject::getArrayObject () should skip proteced or
private properties https://bugs.php.net/bug.php?id=55211
Looks good.
#55128 SplFixedArray::fromArray() does not use extended class
This doesn't look like a good idea. The constructor is not called (and in
general can't be, since we can't know how the subclass constructor looks
like), so the new object can be in an illegal state.
--
Gustavo Lopes
2011/7/26 Gustavo Lopes glopes@nebm.ist.utl.pt:
Em Tue, 26 Jul 2011 06:42:50 +0100, Laruence laruence@php.net escreveu:
2011/7/25 Laruence laruence@php.net:
Hi:
recently I was working on PHP bugs.and submit 3 patches,
#36944 strncmp & negative len
https://bugs.php.net/bug.php?id=36944Looks good, but I didn't got through it thoroughly to check the consistency
of the signs.#54556 array access to empty var does not trigger a notice
https://bugs.php.net/bug.php?id=54556Won't this be affected?
<?php
$foo[] = 'bar';
no, this situation won't be affected
I don't see a good reason for this not to be allowed.
#55211 ArrayObject::getArrayObject () should skip proteced or
private properties https://bugs.php.net/bug.php?id=55211Looks good.
#55128 SplFixedArray::fromArray() does not use extended class
This doesn't look like a good idea. The constructor is not called (and in
general can't be, since we can't know how the subclass constructor looks
like), so the new object can be in an illegal state.
After much thought, I think there maybe no reason for fixedarray
extended class to define it's own constructor, since we provide
fixedarrary::__construct and fromArray already, and extended class
should only get an instance through calling them.
so I think we can make fixedarray::__construct final to make this feature works.
--
Gustavo Lopes--
thanks
--
Laruence Xinchen Hui
http://www.laruence.com/
Em Tue, 26 Jul 2011 12:14:15 +0100, Laruence laruence@php.net escreveu:
2011/7/26 Gustavo Lopes glopes@nebm.ist.utl.pt:
Em Tue, 26 Jul 2011 06:42:50 +0100, Laruence laruence@php.net
escreveu:2011/7/25 Laruence laruence@php.net:
#54556 array access to empty var does not trigger a notice
https://bugs.php.net/bug.php?id=54556Won't this be affected?
<?php
$foo[] = 'bar';no, this situation won't be affected
Ah, if this is only for read situations, a notice seems appropriate.
#55128 SplFixedArray::fromArray() does not use extended class
This doesn't look like a good idea. The constructor is not called (and
in general can't be, since we can't know how the subclass constructor
looks
like), so the new object can be in an illegal state.After much thought, I think there maybe no reason for fixedarray
extended class to define it's own constructor, since we provide
fixedarrary::__construct and fromArray already, and extended class
should only get an instance through calling them.so I think we can make fixedarray::__construct final to make this
feature works.
I disagree. Besides being a BC break, there's no good reason to make the
constructor final and it has the disadvantage of severely limiting the
subclasses.
Instead of using LSB, I think a better option would be to provided a
protected final instance method that would do this special form of
initialization from an array. Subclasses could then write their own static
method (possibly with the same name) for initializing from an array or
even accept an array as a constructor argument. This is a bit more work
and less magic than LSB, but much more versatile.
--
Gustavo Lopes