Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54208
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.170 as permitted sender)
MIME-Version: 1.0
Sender: laruence@gmail.com
In-Reply-To: <op.vy7x9iv0idpuyk@clk-0081.mshome.net>
References: <CABBJUpeqWM3_Gw=dzNMknE80dPe0fQCDXO9DPL6J+Egv6ktACg@mail.gmail.com>
	<CABBJUpd1Xssx+oa-f8__bTqmnavkN6d=sX19N_vvsvx8JXtFmQ@mail.gmail.com>
	<op.vy7x9iv0idpuyk@clk-0081.mshome.net>
Date: Tue, 26 Jul 2011 19:14:15 +0800
Message-ID: <CABBJUpeTgyZKGg9XxVMaaHiLJPs+HWhwAjFYUeqN0C-Ut+0Ydw@mail.gmail.com>
To: Gustavo Lopes <glopes@nebm.ist.utl.pt>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: [Patches]#36944, #54556, #55211(and svn karma applying)
From: laruence@php.net (Laruence)

2011/7/26 Gustavo Lopes <glopes@nebm.ist.utl.pt>:
> Em Tue, 26 Jul 2011 06:42:50 +0100, Laruence <laruence@php.net> escreveu:
>
>> 2011/7/25 Laruence <laruence@php.net>:
>>>
>>> Hi:
>>> =C2=A0 recently I was working on PHP bugs.
>>>
>>> =C2=A0 and =C2=A0submit 3 patches,
>>>
>>> =C2=A0 #36944 =C2=A0 =C2=A0 =C2=A0strncmp & negative len
>>> https://bugs.php.net/bug.php?id=3D36944
>
> Looks good, but I didn't got through it thoroughly to check the consisten=
cy
> of the signs.
>
>>> =C2=A0 #54556 =C2=A0array access to empty var does not trigger a notice
>>> https://bugs.php.net/bug.php?id=3D54556
>
> Won't this be affected?
>
> <?php
> $foo[] =3D 'bar';
>
no, this situation won't be affected
> I don't see a good reason for this not to be allowed.
>
>>> =C2=A0 #55211 =C2=A0ArrayObject::getArrayObject () should skip proteced=
 or
>>> private properties https://bugs.php.net/bug.php?id=3D55211
>
> Looks good.
>
>>
>> =C2=A0 #55128 SplFixedArray::fromArray() does not use extended class
>
> This doesn't look like a good idea. The constructor is not called (and in
> general can't be, since we can't know how the subclass constructor looks
> like), so the new object can be in an illegal state.
>
After much thought, I think there maybe no reason for fixedarray
extended class  to define it's own constructor, since we provide
fixedarrary::__construct and fromArray already, and extended class
should only get an instance through calling them.

so I think we can make fixedarray::__construct final to make this feature w=
orks.
> --
> Gustavo Lopes
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

thanks

--=20
Laruence =C2=A0Xinchen Hui
http://www.laruence.com/