Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54205
Return-Path: <glopes@nebm.ist.utl.pt>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 75895 invoked from network); 26 Jul 2011 09:06:53 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 26 Jul 2011 09:06:53 -0000
Authentication-Results: pb1.pair.com header.from=glopes@nebm.ist.utl.pt; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=glopes@nebm.ist.utl.pt; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.22 cause and error)
X-PHP-List-Original-Sender: glopes@nebm.ist.utl.pt
X-Host-Fingerprint: 193.136.128.22 smtp2.ist.utl.pt Linux 2.6
Received: from [193.136.128.22] ([193.136.128.22:57241] helo=smtp2.ist.utl.pt)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 98/14-48186-9A38E2E4 for <internals@lists.php.net>; Tue, 26 Jul 2011 05:06:50 -0400
Received: from localhost (localhost.localdomain [127.0.0.1])
	by smtp2.ist.utl.pt (Postfix) with ESMTP id 2223A7000439
	for <internals@lists.php.net>; Tue, 26 Jul 2011 10:06:46 +0100 (WEST)
X-Virus-Scanned: by amavisd-new-2.6.4 (20090625) (Debian) at ist.utl.pt
Received: from smtp2.ist.utl.pt ([127.0.0.1])
	by localhost (smtp2.ist.utl.pt [127.0.0.1]) (amavisd-new, port 10025)
	with LMTP id MGnjrE+Kl7R5 for <internals@lists.php.net>;
	Tue, 26 Jul 2011 10:06:45 +0100 (WEST)
Received: from mail2.ist.utl.pt (mail.ist.utl.pt [IPv6:2001:690:2100:1::8])
	by smtp2.ist.utl.pt (Postfix) with ESMTP id DC78F7000436
	for <internals@lists.php.net>; Tue, 26 Jul 2011 10:06:45 +0100 (WEST)
Received: from clk-0081.mshome.net (unknown [85.139.253.17])
	(Authenticated sender: ist155741)
	by mail2.ist.utl.pt (Postfix) with ESMTPSA id BCBF02007317
	for <internals@lists.php.net>; Tue, 26 Jul 2011 10:06:45 +0100 (WEST)
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: internals@lists.php.net
References: <CABBJUpeqWM3_Gw=dzNMknE80dPe0fQCDXO9DPL6J+Egv6ktACg@mail.gmail.com> <CABBJUpd1Xssx+oa-f8__bTqmnavkN6d=sX19N_vvsvx8JXtFmQ@mail.gmail.com>
Date: Tue, 26 Jul 2011 10:06:44 +0100
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Organization: =?utf-8?Q?N=C3=BAcleo_de_Eng=2E_Biom=C3=A9di?=
 =?utf-8?Q?ca_do_I=2ES=2ET=2E?=
Message-ID: <op.vy7x9iv0idpuyk@clk-0081.mshome.net>
In-Reply-To: <CABBJUpd1Xssx+oa-f8__bTqmnavkN6d=sX19N_vvsvx8JXtFmQ@mail.gmail.com>
User-Agent: Opera Mail/11.50 (Win32)
Subject: Re: [PHP-DEV] Re: [Patches]#36944, #54556, #55211(and svn karma
 applying)
From: glopes@nebm.ist.utl.pt ("Gustavo Lopes")

Em Tue, 26 Jul 2011 06:42:50 +0100, Laruence <laruence@php.net> escreveu:

> 2011/7/25 Laruence <laruence@php.net>:
>> Hi:
>>    recently I was working on PHP bugs.
>>
>>    and  submit 3 patches,
>>
>>    #36944      strncmp & negative len  
>> https://bugs.php.net/bug.php?id=36944

Looks good, but I didn't got through it thoroughly to check the  
consistency of the signs.

>>    #54556  array access to empty var does not trigger a notice
>> https://bugs.php.net/bug.php?id=54556

Won't this be affected?

<?php
$foo[] = 'bar';

I don't see a good reason for this not to be allowed.

>>    #55211  ArrayObject::getArrayObject () should skip proteced or
>> private properties https://bugs.php.net/bug.php?id=55211

Looks good.

>
>    #55128 SplFixedArray::fromArray() does not use extended class

This doesn't look like a good idea. The constructor is not called (and in  
general can't be, since we can't know how the subclass constructor looks  
like), so the new object can be in an illegal state.

-- 
Gustavo Lopes