[PATCH] openssl_pkcs7_encrypt to/from variable or file

Hi !

Richard,

I understand very well the benefit of using only one function to do the
same work, but they are already 2 function that does the same for private
keys and for consistency i think i had to submit 2 function to do the same
job for public keys.
Of course the best way is to have only too function to do the job (one for
public and one for private keys) but i just can't decide myself to break
compatibility.

So i submit my two little functions. Sorry this is not a patch.

Regards,
Eric

At 16:59 05/11/2003, Richard Burton wrote:

Eric,

Might I suggest that if you submit a patch for this, you add just one
function and check for a "file://" prefix to determine if the user want to
work with a file or variable? This is the way certificates are handled at
present, and I used this method for my patch to try and be consistent with it.

I'm a big fan of consistency, but I know others' views differ. I guess
it's over to Wez for guidence, since it's his extension?

Richard.

From: Eric COLINET e.colinet@laposte.net
To: internals@lists.php.net
CC: wez@php.net
Subject: Re: [PHP-DEV] [PATCH] openssl_pkcs7_encrypt to/from variable or
file
Date: Wed, 05 Nov 2003 12:57:20 +0100

Hi !

In the same series ..

I have no patch to provide but i've written two functions related to
php_openssl:
openssl_pubkey_export
openssl_pubkey_export_to_file

That simply allow the export of public keys that seems to be not possible
before.

I there is no special reason for that i can submit them (they are small
modification of openssl_pkey_export & openssl_pkey_export_to_file)

Eric

---

Tired of 56k? Get a FREE BT Broadband connection
http://www.msn.co.uk/specials/btbroadband