Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:5311 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 60655 invoked by uid 1010); 7 Nov 2003 10:44:44 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 60620 invoked from network); 7 Nov 2003 10:44:44 -0000 Received: from unknown (HELO mwinf0802.wanadoo.fr) (193.252.22.23) by pb1.pair.com with SMTP; 7 Nov 2003 10:44:44 -0000 Received: from enolas.laposte.net (AMontsouris-108-1-1-101.w80-13.abo.wanadoo.fr [80.13.192.101]) by mwinf0802.wanadoo.fr (SMTP Server) with ESMTP id 99F141800199; Fri, 7 Nov 2003 11:44:43 +0100 (CET) Message-ID: <6.0.0.22.1.20031107113942.01ac8ed0@pop.laposte.net> X-Sender: e.colinet@pop.laposte.net (Unverified) X-Mailer: QUALCOMM Windows Eudora Version 6.0.0.22 Date: Fri, 07 Nov 2003 11:42:58 +0100 To: "Richard Antony Burton" Cc: In-Reply-To: References: <6.0.0.22.1.20031106164010.01aded88@pop.laposte.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] [PATCH] openssl_pkcs7_encrypt to/from variable or file From: e.colinet@laposte.net (Eric COLINET) Hi ! It's a problem for sure... Wez ? what do you think about that ? At 17:33 06/11/2003, Richard Antony Burton wrote: >Eric, > >Appologies, I should have been more careful to check I actually knew what I >was talking about before I opened my mouth ;-) Didn't realise the existing >private key version came in two separate functions like this. As I said, I'm >a big fan of consistency, but I guess we have two precedents here - so >either is good? > >I have to follow the other method for my patch, since there are two >parameters to the function which could be either a variable or file, >otherwise we would need four versions of the function to cover all >combinations! > >Richard. > >----- Original Message ----- >From: "Eric COLINET" >To: "Richard Burton" ; >Sent: Thursday, November 06, 2003 4:19 PM >Subject: Re: [PHP-DEV] [PATCH] openssl_pkcs7_encrypt to/from variable or >file > > > > Hi ! > > > > Richard, > > > > I understand very well the benefit of using only one function to do the > > same work, but they are already 2 function that does the same for private > > keys and for consistency i think i had to submit 2 function to do the same > > job for public keys. > > Of course the best way is to have only too function to do the job (one for > > public and one for private keys) but i just can't decide myself to break > > compatibility. > >-- >PHP Internals - PHP Runtime Development Mailing List >To unsubscribe, visit: http://www.php.net/unsub.php