Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:5300 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 7357 invoked by uid 1010); 6 Nov 2003 16:33:05 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 7333 invoked from network); 6 Nov 2003 16:33:04 -0000 Received: from unknown (HELO hotmail.com) (65.54.246.196) by pb1.pair.com with SMTP; 6 Nov 2003 16:33:04 -0000 Received: from mail pickup service by hotmail.com with Microsoft SMTPSVC; Thu, 6 Nov 2003 08:33:04 -0800 Received: from 195.166.158.131 by bay2-dav61.bay2.hotmail.com with DAV; Thu, 06 Nov 2003 16:33:04 +0000 X-Originating-IP: [195.166.158.131] X-Originating-Email: [richardaburton@hotmail.com] To: "Eric COLINET" Cc: References: <6.0.0.22.1.20031106164010.01aded88@pop.laposte.net> Date: Thu, 6 Nov 2003 16:33:03 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1158 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 Message-ID: X-OriginalArrivalTime: 06 Nov 2003 16:33:04.0281 (UTC) FILETIME=[A6CFC090:01C3A483] Subject: Re: [PHP-DEV] [PATCH] openssl_pkcs7_encrypt to/from variable or file From: richardaburton@hotmail.com ("Richard Antony Burton") Eric, Appologies, I should have been more careful to check I actually knew what I was talking about before I opened my mouth ;-) Didn't realise the existing private key version came in two separate functions like this. As I said, I'm a big fan of consistency, but I guess we have two precedents here - so either is good? I have to follow the other method for my patch, since there are two parameters to the function which could be either a variable or file, otherwise we would need four versions of the function to cover all combinations! Richard. ----- Original Message ----- From: "Eric COLINET" To: "Richard Burton" ; Sent: Thursday, November 06, 2003 4:19 PM Subject: Re: [PHP-DEV] [PATCH] openssl_pkcs7_encrypt to/from variable or file > Hi ! > > Richard, > > I understand very well the benefit of using only one function to do the > same work, but they are already 2 function that does the same for private > keys and for consistency i think i had to submit 2 function to do the same > job for public keys. > Of course the best way is to have only too function to do the job (one for > public and one for private keys) but i just can't decide myself to break > compatibility.