Fixed - thanks!

--Wez.

----- Original Message -----
From: "Joe Orton" jorton@redhat.com
To: internals@lists.php.net
Sent: Monday, October 13, 2003 11:50 AM
Subject: [PHP-DEV] [PATCH] fix some gcc warnings

4.3/ext/openssl/openssl.c: In function zif_openssl_csr_sign': 4.3/ext/openssl/openssl.c:1436: warning:priv_key' might be used
uninitialized in this function
4.3/ext/gmp/gmp.c: In function gmp_zval_binary_ui_op2_ex': 4.3/ext/gmp/gmp.c:314: warning:long_result' might be used uninitialized
in this function

The gmp code is actually OK, but the openssl code is not.

Index: ext/gmp/gmp.c

RCS file: /repository/php-src/ext/gmp/gmp.c,v
retrieving revision 1.29.4.2
diff -u -r1.29.4.2 gmp.c
--- ext/gmp/gmp.c 13 Mar 2003 16:18:10 -0000 1.29.4.2
+++ ext/gmp/gmp.c 13 Oct 2003 10:44:21 -0000
@@ -311,7 +311,7 @@
mpz_t *gmpnum_a, *gmpnum_b, *gmpnum_result1, *gmpnum_result2;
zval r;
int use_ui=0;

• unsigned long long_result;

• unsigned long long_result=0;

  FETCH_GMP_ZVAL(gmpnum_a, a_arg);
  if(gmp_ui_op && Z_TYPE_PP(b_arg) == IS_LONG && Z_LVAL_PP(b_arg) >= 0) {
  Index: ext/openssl/openssl.c
  ===================================================================
  RCS file: /repository/php-src/ext/openssl/openssl.c,v
  retrieving revision 1.52.2.16
  diff -u -r1.52.2.16 openssl.c
  --- ext/openssl/openssl.c 23 Sep 2003 14:52:25 -0000 1.52.2.16
  +++ ext/openssl/openssl.c 13 Oct 2003 10:44:22 -0000
  @@ -1433,7 +1433,7 @@
  long serial = 0L;
  X509 * cert = NULL, *new_cert = NULL;
  X509_REQ * csr;

• EVP_PKEY * key = NULL, *priv_key;

• EVP_PKEY * key = NULL, *priv_key = NULL;
  long csr_resource, certresource, keyresource;
  int i;
  struct php_x509_request req;