Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:4813 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 88807 invoked by uid 1010); 13 Oct 2003 11:48:01 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 88762 invoked from network); 13 Oct 2003 11:48:01 -0000 Received: from unknown (HELO mx.thebrainroom.net) (65.200.24.98) by pb1.pair.com with SMTP; 13 Oct 2003 11:48:01 -0000 Received: by mx.thebrainroom.net (Postfix, from userid 517) id 76E661488089; Mon, 13 Oct 2003 04:46:18 -0700 (PDT) Received: from zaneeb.thebrainroom.net (zaneeb.thebrainroom.net [82.133.1.138]) by mx.thebrainroom.net (Postfix) with ESMTP id 8D2D71488087; Mon, 13 Oct 2003 04:46:16 -0700 (PDT) Received: from titan (titan.thebrainroom.net [82.133.1.139]) by zaneeb.thebrainroom.net (8.11.6/8.11.6) with SMTP id h9DBlwK18472; Mon, 13 Oct 2003 12:47:58 +0100 Message-ID: <01ad01c3917f$d9dba330$8b018552@titan> To: "Joe Orton" , References: <20031013105046.GA19957@redhat.com> Date: Mon, 13 Oct 2003 12:47:59 +0100 Organization: The Brain Room Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.3790.0 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.3790.0 X-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,QUOTED_EMAIL_TEXT,REFERENCES version=2.55 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) X-TBR-Filter: Virus scanned and defanged Subject: Re: [PHP-DEV] [PATCH] fix some gcc warnings From: wez@thebrainroom.com ("Wez Furlong") Fixed - thanks! --Wez. ----- Original Message ----- From: "Joe Orton" To: Sent: Monday, October 13, 2003 11:50 AM Subject: [PHP-DEV] [PATCH] fix some gcc warnings > 4.3/ext/openssl/openssl.c: In function `zif_openssl_csr_sign': > 4.3/ext/openssl/openssl.c:1436: warning: `priv_key' might be used uninitialized in this function > 4.3/ext/gmp/gmp.c: In function `gmp_zval_binary_ui_op2_ex': > 4.3/ext/gmp/gmp.c:314: warning: `long_result' might be used uninitialized in this function > > The gmp code is actually OK, but the openssl code is not. > > Index: ext/gmp/gmp.c > =================================================================== > RCS file: /repository/php-src/ext/gmp/gmp.c,v > retrieving revision 1.29.4.2 > diff -u -r1.29.4.2 gmp.c > --- ext/gmp/gmp.c 13 Mar 2003 16:18:10 -0000 1.29.4.2 > +++ ext/gmp/gmp.c 13 Oct 2003 10:44:21 -0000 > @@ -311,7 +311,7 @@ > mpz_t *gmpnum_a, *gmpnum_b, *gmpnum_result1, *gmpnum_result2; > zval r; > int use_ui=0; > - unsigned long long_result; > + unsigned long long_result=0; > > FETCH_GMP_ZVAL(gmpnum_a, a_arg); > if(gmp_ui_op && Z_TYPE_PP(b_arg) == IS_LONG && Z_LVAL_PP(b_arg) >= 0) { > Index: ext/openssl/openssl.c > =================================================================== > RCS file: /repository/php-src/ext/openssl/openssl.c,v > retrieving revision 1.52.2.16 > diff -u -r1.52.2.16 openssl.c > --- ext/openssl/openssl.c 23 Sep 2003 14:52:25 -0000 1.52.2.16 > +++ ext/openssl/openssl.c 13 Oct 2003 10:44:22 -0000 > @@ -1433,7 +1433,7 @@ > long serial = 0L; > X509 * cert = NULL, *new_cert = NULL; > X509_REQ * csr; > - EVP_PKEY * key = NULL, *priv_key; > + EVP_PKEY * key = NULL, *priv_key = NULL; > long csr_resource, certresource, keyresource; > int i; > struct php_x509_request req;