Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:4809 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 7229 invoked by uid 1010); 13 Oct 2003 10:50:49 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 7205 invoked from network); 13 Oct 2003 10:50:49 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by pb1.pair.com with SMTP; 13 Oct 2003 10:50:49 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h9DAonM09843 for ; Mon, 13 Oct 2003 06:50:49 -0400 Received: from lacrosse.corp.redhat.com (lacrosse.corp.redhat.com [172.16.52.154]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9DAonr18031 for ; Mon, 13 Oct 2003 06:50:49 -0400 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by lacrosse.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9DAomJ09969 for ; Mon, 13 Oct 2003 06:50:48 -0400 Received: from radish.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by radish.cambridge.redhat.com (8.12.10/8.12.7) with ESMTP id h9DAolSV008692 for ; Mon, 13 Oct 2003 11:50:47 +0100 Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.12.10/8.12.10/Submit) id h9DAok7N008691 for internals@lists.php.net; Mon, 13 Oct 2003 11:50:46 +0100 Date: Mon, 13 Oct 2003 11:50:46 +0100 To: internals@lists.php.net Message-ID: <20031013105046.GA19957@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Subject: [PATCH] fix some gcc warnings From: jorton@redhat.com (Joe Orton) 4.3/ext/openssl/openssl.c: In function `zif_openssl_csr_sign': 4.3/ext/openssl/openssl.c:1436: warning: `priv_key' might be used uninitialized in this function 4.3/ext/gmp/gmp.c: In function `gmp_zval_binary_ui_op2_ex': 4.3/ext/gmp/gmp.c:314: warning: `long_result' might be used uninitialized in this function The gmp code is actually OK, but the openssl code is not. Index: ext/gmp/gmp.c =================================================================== RCS file: /repository/php-src/ext/gmp/gmp.c,v retrieving revision 1.29.4.2 diff -u -r1.29.4.2 gmp.c --- ext/gmp/gmp.c 13 Mar 2003 16:18:10 -0000 1.29.4.2 +++ ext/gmp/gmp.c 13 Oct 2003 10:44:21 -0000 @@ -311,7 +311,7 @@ mpz_t *gmpnum_a, *gmpnum_b, *gmpnum_result1, *gmpnum_result2; zval r; int use_ui=0; - unsigned long long_result; + unsigned long long_result=0; FETCH_GMP_ZVAL(gmpnum_a, a_arg); if(gmp_ui_op && Z_TYPE_PP(b_arg) == IS_LONG && Z_LVAL_PP(b_arg) >= 0) { Index: ext/openssl/openssl.c =================================================================== RCS file: /repository/php-src/ext/openssl/openssl.c,v retrieving revision 1.52.2.16 diff -u -r1.52.2.16 openssl.c --- ext/openssl/openssl.c 23 Sep 2003 14:52:25 -0000 1.52.2.16 +++ ext/openssl/openssl.c 13 Oct 2003 10:44:22 -0000 @@ -1433,7 +1433,7 @@ long serial = 0L; X509 * cert = NULL, *new_cert = NULL; X509_REQ * csr; - EVP_PKEY * key = NULL, *priv_key; + EVP_PKEY * key = NULL, *priv_key = NULL; long csr_resource, certresource, keyresource; int i; struct php_x509_request req;