Hi,
now that a new trunk is about to be created some comments about 5.3:
PHP_5_3 is a stable branch. This means mostly bug fixes. Small features
(like array_seek) can be added. There won't be a strict rule about what
is "small", common sense and asking applies. That part will become
stricter once the next major (5.4/6) release comes closer.
In general every bug fix should have a test and bug ID, every new
feature should have documentation.
johannes
now that a new trunk is about to be created some comments about 5.3:
PHP_5_3 is a stable branch. This means mostly bug fixes. Small features
(like array_seek) can be added. There won't be a strict rule about what
is "small", common sense and asking applies. That part will become
stricter once the next major (5.4/6) release comes closer.
There were some comments that this might not have been clear enough:
This doesn't mean "simply add features" but quick heads up before
committing/merging would be strongly preferred.
5.3 is a stable branch and even small additions add some risk.
johannes
Johannes Schlüter wrote:
Hi,
now that a new trunk is about to be created some comments about 5.3:
PHP_5_3 is a stable branch. This means mostly bug fixes. Small features
(like array_seek) can be added. There won't be a strict rule about what
is "small", common sense and asking applies. That part will become
stricter once the next major (5.4/6) release comes closer.In general every bug fix should have a test and bug ID, every new
feature should have documentation.
I was considering adding support for tokyo cabinets, would that still be
acceptable for 5.3.x?
Cheers,
Raphael Geissert
Am 18.03.2010 19:10, schrieb Raphael Geissert:
I was considering adding support for tokyo cabinets, would that still
be acceptable for 5.3.x?
I think something like that should go into a PECL extension.
--
Sebastian Bergmann Co-Founder and Principal Consultant
http://sebastian-bergmann.de/ http://thePHP.cc/
Sebastian Bergmann wrote:
Am 18.03.2010 19:10, schrieb Raphael Geissert:
I was considering adding support for tokyo cabinets, would that still
be acceptable for 5.3.x?I think something like that should go into a PECL extension.
I would actually be happy if I could build support for dba handlers as
separate extensions, but that doesn't seem to be the case. Correct me if I'm
wrong.
Here I'm talking about adding support for tokyo cabinets as a dba handler,
not a complete interface to the multiple tokyo cabinet APIs.
Cheers,
Raphael Geissert
I would actually be happy if I could build support for dba handlers as
separate extensions, but that doesn't seem to be the case. Correct me if I'm
wrong.Here I'm talking about adding support for tokyo cabinets as a dba handler,
not a complete interface to the multiple tokyo cabinet APIs.
Are you sure you want to add it to ext/dba?
dba is .. well.. dead, and it sound like a complete waste of time.
--
Wbr,
Antony Dovgal
http://pinba.org - realtime statistics for PHP
Antony Dovgal wrote:
Here I'm talking about adding support for tokyo cabinets as a dba handler,
not a complete interface to the multiple tokyo cabinet APIs.Are you sure you want to add it to ext/dba?
dba is .. well.. dead, and it sound like a complete waste of time.
There is an item on the wishlist for PHP 6.0 about refactoring ext/dba
to use PDO-style drivers. I intend to investigate this, unless someone
else wants to. In addition, I wrote a patch for Tokyo Cabinet support
for ext/dba a while back, which Scott applied to PHP6 - I was rather
hoping it'd end up in 5.3.x at some point, but he's been too busy. I'll
dig out the patch if anyone here wants it, I haven't karma to apply it.
--
Cheers,
Michael
Michael Maclean wrote:
Antony Dovgal wrote:
Here I'm talking about adding support for tokyo cabinets as a dba
handler, not a complete interface to the multiple tokyo cabinet APIs.Are you sure you want to add it to ext/dba?
dba is .. well.. dead, and it sound like a complete waste of time.
At the moment dba is the best place to add support for tokyo cabinets
without introducing major features (or a pecl extension).
There is an item on the wishlist for PHP 6.0 about refactoring ext/dba
to use PDO-style drivers. I intend to investigate this, unless someone
else wants to.
That'd be great. In fact, the interface isn't really bad. It is surely
missing multiple features, some of which are only supported by a couple of
dbms, but the code behind is what really needs to be improved.
In addition, I wrote a patch for Tokyo Cabinet support
for ext/dba a while back, which Scott applied to PHP6 - I was rather
hoping it'd end up in 5.3.x at some point, but he's been too busy. I'll
dig out the patch if anyone here wants it, I haven't karma to apply it.
Cool.
Johannes, would it be ok to merge support for tokyo cabinets into PHP_5_3?
Cheers,
Raphael Geissert
Hi,
At the moment dba is the best place to add support for tokyo cabinets
without introducing major features (or a pecl extension).
"without introducing major features" doesn't sound like a good way for
architecture decisions. This sounds a bit like "let's do it the way we
can trick the process" to me.
And there is a pecl extension: http://pecl.php.net/package/tokyo_tyrant
That'd be great. In fact, the interface isn't really bad. It is surely
missing multiple features, some of which are only supported by a couple of
dbms, but the code behind is what really needs to be improved.
Thanks for volunteering! :-)
In addition, I wrote a patch for Tokyo Cabinet support
for ext/dba a while back, which Scott applied to PHP6 - I was rather
hoping it'd end up in 5.3.x at some point, but he's been too busy. I'll
dig out the patch if anyone here wants it, I haven't karma to apply it.Cool.
Johannes, would it be ok to merge support for tokyo cabinets into PHP_5_3?
I didn't review it, yet, it sounds like a bit much, putting the review
on my todo.
johannes
Johannes Schlüter wrote:
At the moment dba is the best place to add support for tokyo cabinets
without introducing major features (or a pecl extension)."without introducing major features" doesn't sound like a good way for
architecture decisions. This sounds a bit like "let's do it the way we
can trick the process" to me.
Well, it is just another handler :)
And there is a pecl extension: http://pecl.php.net/package/tokyo_tyrant
Which doesn't address the same problem. Tokyo tyrant is a DBMS internally
using tokyo cabinets. There are cases where running tokyo tyrant is either
not possible, an overkill or not the right solution to a problem, hence the
request of the dba handler.
That'd be great. In fact, the interface isn't really bad. It is surely
missing multiple features, some of which are only supported by a couple
of dbms, but the code behind is what really needs to be improved.Thanks for volunteering! :-)
Meh :)
In addition, I wrote a patch for Tokyo Cabinet support
for ext/dba a while back, which Scott applied to PHP6 - I was rather
hoping it'd end up in 5.3.x at some point, but he's been too busy. I'll
dig out the patch if anyone here wants it, I haven't karma to apply it.Cool.
Johannes, would it be ok to merge support for tokyo cabinets into
PHP_5_3?I didn't review it, yet, it sounds like a bit much, putting the review
on my todo.
Would be great if it is merged. Thanks in advance.
Cheers,
Raphael Geissert
Here I'm talking about adding support for tokyo cabinets as a dba handler,
not a complete interface to the multiple tokyo cabinet APIs.
This is already in old-trunk:
http://svn.php.net/repository/php/php-src/branches/FIRST_UNICODE_IMPLEMENTATION/NEWS
- Improved ext/dba:
. Added support for Tokyo Cabinet. (Michael)
--
Mikko Koppanen