Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47794 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 82613 invoked from network); 5 Apr 2010 18:06:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 Apr 2010 18:06:09 -0000 X-Host-Fingerprint: 200.52.223.158 unknown Received: from [200.52.223.158] ([200.52.223.158:4619] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3E/63-60700-0962ABB4 for ; Mon, 05 Apr 2010 14:06:08 -0400 Message-ID: <3E.63.60700.0962ABB4@pb1.pair.com> To: internals@lists.php.net Followup-To: php.internals Lines: 45 Date: Mon, 05 Apr 2010 13:05:42 -0500 References: <1268900384.13435.692.camel@guybrush> <4BA28D7A.2080905@daylessday.org> <4BA299C9.3040902@no-surprises.co.uk> <8E.14.31664.869F2AB4@pb1.pair.com> <1269199127.1575.70.camel@guybrush> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8Bit X-Posted-By: 200.52.223.158 Subject: Re: [PHP-DEV] Re: Commits to PHP_5_3 From: geissert@php.net (Raphael Geissert) Johannes Schlüter wrote: > On Thu, 2010-03-18 at 22:10 -0600, Raphael Geissert wrote: >> At the moment dba is the best place to add support for tokyo cabinets >> without introducing major features (or a pecl extension). > > "without introducing major features" doesn't sound like a good way for > architecture decisions. This sounds a bit like "let's do it the way we > can trick the process" to me. Well, it is just another handler :) > And there is a pecl extension: http://pecl.php.net/package/tokyo_tyrant > Which doesn't address the same problem. Tokyo tyrant is a DBMS internally using tokyo cabinets. There are cases where running tokyo tyrant is either not possible, an overkill or not the right solution to a problem, hence the request of the dba handler. >> That'd be great. In fact, the interface isn't really bad. It is surely >> missing multiple features, some of which are only supported by a couple >> of dbms, but the code behind is what really needs to be improved. > > Thanks for volunteering! :-) > Meh :) >> > In addition, I wrote a patch for Tokyo Cabinet support >> > for ext/dba a while back, which Scott applied to PHP6 - I was rather >> > hoping it'd end up in 5.3.x at some point, but he's been too busy. I'll >> > dig out the patch if anyone here wants it, I haven't karma to apply it. >> >> Cool. >> >> Johannes, would it be ok to merge support for tokyo cabinets into >> PHP_5_3? > > I didn't review it, yet, it sounds like a bit much, putting the review > on my todo. Would be great if it is merged. Thanks in advance. Cheers, -- Raphael Geissert