Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47443 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 3236 invoked from network); 21 Mar 2010 19:18:54 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Mar 2010 19:18:54 -0000 Authentication-Results: pb1.pair.com smtp.mail=johannes@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=johannes@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 83.243.58.134 as permitted sender) X-PHP-List-Original-Sender: johannes@php.net X-Host-Fingerprint: 83.243.58.134 mailout2.netbeat.de Linux 2.6 Received: from [83.243.58.134] ([83.243.58.134:46468] helo=mailout2.netbeat.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A7/03-58938-C1176AB4 for ; Sun, 21 Mar 2010 14:18:53 -0500 Received: (qmail 6842 invoked by uid 89); 21 Mar 2010 19:14:03 -0000 Received: from unknown (HELO ?192.168.1.28?) (postmaster%schlueters.de@93.104.60.70) by mailout2.netbeat.de with ESMTPA; 21 Mar 2010 19:14:03 -0000 X-Originator: 9e51b244e0a38413ab6a9876e36ba9df To: Raphael Geissert Cc: internals@lists.php.net In-Reply-To: <8E.14.31664.869F2AB4@pb1.pair.com> References: <1268900384.13435.692.camel@guybrush> <4BA28D7A.2080905@daylessday.org> <4BA299C9.3040902@no-surprises.co.uk> <8E.14.31664.869F2AB4@pb1.pair.com> Content-Type: text/plain; charset="UTF-8" Organization: php.net Date: Sun, 21 Mar 2010 20:18:47 +0100 Message-ID: <1269199127.1575.70.camel@guybrush> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: Commits to PHP_5_3 From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=) Hi, On Thu, 2010-03-18 at 22:10 -0600, Raphael Geissert wrote: > At the moment dba is the best place to add support for tokyo cabinets > without introducing major features (or a pecl extension). "without introducing major features" doesn't sound like a good way for architecture decisions. This sounds a bit like "let's do it the way we can trick the process" to me. And there is a pecl extension: http://pecl.php.net/package/tokyo_tyrant > That'd be great. In fact, the interface isn't really bad. It is surely > missing multiple features, some of which are only supported by a couple of > dbms, but the code behind is what really needs to be improved. Thanks for volunteering! :-) > > In addition, I wrote a patch for Tokyo Cabinet support > > for ext/dba a while back, which Scott applied to PHP6 - I was rather > > hoping it'd end up in 5.3.x at some point, but he's been too busy. I'll > > dig out the patch if anyone here wants it, I haven't karma to apply it. > > Cool. > > Johannes, would it be ok to merge support for tokyo cabinets into PHP_5_3? I didn't review it, yet, it sounds like a bit much, putting the review on my todo. johannes