Hi List,
I recently discovered that zend_hash_func is equal to
zend_get_hash_value. To clean this up, I would like to remove
zend_hash_func in favor of zend_get_hash in HEAD. If there are no
objections I would commit a patch in a few days.
David
2009/5/26 David Soria Parra dsoria@gmx.net:
Hi List,
I recently discovered that zend_hash_func is equal to zend_get_hash_value.
To clean this up, I would like to remove zend_hash_func in favor of
zend_get_hash in HEAD. If there are no objections I would commit a patch in
a few days.
Did you grep through pecl and the source to make sure it won't break
anything? If you did, then I see no problems.
--
Slan,
David
Hi List,
I recently discovered that zend_hash_func is equal to
zend_get_hash_value. To clean this up, I would like to remove
zend_hash_func in favor of zend_get_hash in HEAD. If there are no
objections I would commit a patch in a few days.
12:48 <@tony2001> dsp__: I see no point in removing it completely and breaking BC for no reason
12:48 <@tony2001> you can remove it, but leave a macro to make sure old code still works
--
Wbr,
Antony Dovgal
http://pinba.org - realtime statistics for PHP
Antony Dovgal wrote:
Hi List,
I recently discovered that zend_hash_func is equal to
zend_get_hash_value. To clean this up, I would like to remove
zend_hash_func in favor of zend_get_hash in HEAD. If there are no
objections I would commit a patch in a few days.12:48<@tony2001> dsp__: I see no point in removing it completely and breaking BC for no reason
12:48<@tony2001> you can remove it, but leave a macro to make sure old code still works
I would like to see us clean up items like this as part of the PHP-6 release, part of the list of todo items was to get rid of any bits like this that can be unnecessarily confusing etc.
I do think it should be done in a way that deprecates one of the functions, but not the other to make migration easier for extensions (unless we have a compelling reason for a complete rename).
-shire
12:48<@tony2001> you can remove it, but leave a macro to make sure old code still works
or just use attribute((alias("...."))); ...
David Soria Parra escribió:
Hi List,
I recently discovered that zend_hash_func is equal to
zend_get_hash_value. To clean this up, I would like to remove
zend_hash_func in favor of zend_get_hash in HEAD. If there are no
objections I would commit a patch in a few days.
We can start with the attached patch and then remove it in the future...
--
"If this is the best God can do, I am not impressed" -George Carlin
(1937-2008)
Cristian Rodríguez R.
Software Developer
Platform/OpenSUSE - Core Services
SUSE LINUX Products GmbH
Research & Development
http://www.opensuse.org/
Cristian Rodríguez wrote:
David Soria Parra escribió:
Hi List,
I recently discovered that zend_hash_func is equal to
zend_get_hash_value. To clean this up, I would like to remove
zend_hash_func in favor of zend_get_hash in HEAD. If there are no
objections I would commit a patch in a few days.We can start with the attached patch and then remove it in the future...
Yeah, althoughI would suggest we put this patch as a TODO for php-5.4, and then completely remove it in 6
-shire
Cristian Rodríguez wrote:
David Soria Parra escribió:
Hi List,
I recently discovered that zend_hash_func is equal to
zend_get_hash_value. To clean this up, I would like to remove
zend_hash_func in favor of zend_get_hash in HEAD. If there are no
objections I would commit a patch in a few days.We can start with the attached patch and then remove it in the
future...Yeah, althoughI would suggest we put this patch as a TODO for
php-5.4, and then completely remove it in 6
just FYI ..
from all i have heard from people, the next version will be 6.0, there
might be a 5.4 after 6.0 that back ports some stuff and more
importantly adds soem forwards compatibility. but for now lets focus
on 6.0 (well after relasing 5.3).
regards,
Lukas Kahwe Smith
mls@pooteeweet.org