Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:44071
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain tekrat.com from 208.43.138.18 cause and error)
Message-ID: <4A1C76C2.80400@tekrat.com>
Date: Tue, 26 May 2009 16:09:54 -0700
User-Agent: Postbox 1.0b12 (Macintosh/2009051120)
MIME-Version: 1.0
To: Antony Dovgal <tony@daylessday.org>
CC: David Soria Parra <dsoria@gmx.net>, internals@lists.php.net
References: <4A1BDCF3.1020703@gmx.net> <4A1BE23A.7000408@daylessday.org>
In-Reply-To: <4A1BE23A.7000408@daylessday.org>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Removing zend_hash_func in PHP 6.0
From: shire@tekrat.com (shire)

Antony Dovgal wrote:
> On 26.05.2009 16:13, David Soria Parra wrote:
>> Hi List,
>>
>> I recently discovered that zend_hash_func is equal to
>> zend_get_hash_value. To clean this up, I would like to remove
>> zend_hash_func in favor of zend_get_hash in HEAD. If there are no
>> objections I would commit a patch in a few days.
>
> 12:48<@tony2001>  dsp__: I see no point in removing it completely and breaking BC for no reason
> 12:48<@tony2001>  you can remove it, but leave a macro to make sure old code still works
>

I would like to see us clean up items like this as part of the PHP-6 release, part of the list of todo items was to get rid of any bits like this that can be unnecessarily confusing etc.

I do think it should be done in a way that deprecates one of the functions, but not the other to make migration easier for extensions (unless we have a compelling reason for a complete rename).

-shire