Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:44092
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain suse.de from 195.135.220.15 cause and error)
Message-ID: <4A1FDA44.7060808@suse.de>
Date: Fri, 29 May 2009 08:51:16 -0400
Organization: Platform/OpenSUSE - Core Services, SUSE LINUX Products GmbH,
 Research & Development 
User-Agent: Thunderbird 2.0.0.18 (X11/20081112)
MIME-Version: 1.0
To: internals@lists.php.net
References: <4A1BDCF3.1020703@gmx.net>
In-Reply-To: <4A1BDCF3.1020703@gmx.net>
OpenPGP: id=85898BD3
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enig2373C3209B9AA3ED77A02369"
Subject: Re: [PHP-DEV] Removing zend_hash_func in PHP 6.0
From: crrodriguez@suse.de (=?UTF-8?B?Q3Jpc3RpYW4gUm9kcsOtZ3Vleg==?=)

--------------enig2373C3209B9AA3ED77A02369
Content-Type: multipart/mixed;
 boundary="------------020106000505030401090801"

This is a multi-part message in MIME format.
--------------020106000505030401090801
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

David Soria Parra escribi=C3=B3:
> Hi List,
>=20
> I recently discovered that zend_hash_func is equal to
> zend_get_hash_value. To clean this up, I would like to remove
> zend_hash_func in favor of zend_get_hash in HEAD. If there are no
> objections I would commit a patch in a few days.

We can start with the attached patch and then remove it in the future...




--=20
"If this is the best God can do, I am not impressed" -George Carlin
(1937-2008)

Cristian Rodr=C3=ADguez R.
Software Developer
Platform/OpenSUSE - Core Services
SUSE LINUX Products GmbH
Research & Development
http://www.opensuse.org/


--------------020106000505030401090801
Content-Type: text/x-patch;
 name="zend_hash_func_deprecated.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline;
 filename="zend_hash_func_deprecated.patch"

Index: Zend/zend_hash.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /repository/ZendEngine2/zend_hash.h,v
retrieving revision 1.78.2.2.2.2.2.13
diff -u -p -r1.78.2.2.2.2.2.13 zend_hash.h
--- Zend/zend_hash.h	25 May 2009 01:18:00 -0000	1.78.2.2.2.2.2.13
+++ Zend/zend_hash.h	29 May 2009 12:49:31 -0000
@@ -288,7 +288,7 @@ EMPTY_SWITCH_DEFAULT_CASE()
 }
=20
=20
-ZEND_API ulong zend_hash_func(const char *arKey, uint nKeyLength);
+ZEND_API ZEND_ATTRIBUTE_DEPRECATED ulong zend_hash_func(const char *arKe=
y, uint nKeyLength);
=20
 #if ZEND_DEBUG
 /* debug */

--------------020106000505030401090801--

--------------enig2373C3209B9AA3ED77A02369
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkof2kcACgkQhbiInYWJi9NLYgCffskAjjz/bTHI4K+DhGsXDDDM
VcAAnAthP9MgDF+xnt2BncIb1fG9ACjR
=wkp0
-----END PGP SIGNATURE-----

--------------enig2373C3209B9AA3ED77A02369--